Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine rss shrinker and base check lazy imports #34483

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Feb 26, 2025

What does this PR do?

I set this to draft too late, sorry about reviewer pings!

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@iliakur iliakur requested review from a team as code owners February 26, 2025 16:39
@iliakur iliakur marked this pull request as draft February 26, 2025 16:40
Copy link

Go Package Import Differences

Baseline: 407d013
Comparison: 6ddccf2

binaryosarchchange
agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
iot-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
iot-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
cluster-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
cluster-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
process-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-process-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
security-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
security-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
system-probelinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
system-probelinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentlinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentwindowsamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentdarwinamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
trace-agentdarwinarm64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker
heroku-trace-agentlinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/cmd/internal/rssshrinker

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57080008 --os-family=ubuntu

Note: This applies to commit 6ddccf2

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 407d0133d110d9e8303511ffaabf829ec061aace

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 7.75MB ⚠️ 952.09MB 944.33MB 140.00MB
datadog-agent-x86_64-rpm 7.27MB ⚠️ 1207.33MB 1200.06MB 140.00MB
datadog-agent-x86_64-suse 7.27MB ⚠️ 1207.33MB 1200.06MB 140.00MB
datadog-agent-arm64-deb 7.25MB ⚠️ 942.32MB 935.06MB 140.00MB
datadog-agent-amd64-deb 6.77MB ⚠️ 1197.54MB 1190.77MB 140.00MB
datadog-heroku-agent-amd64-deb 6.73MB ⚠️ 511.91MB 505.17MB 70.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

⚠️ Warning

@FlorentClarret
Copy link
Member

(1235 commits behind; 2 months)

:seesomethingsaysomething: Your PR is a tiny bit behind, is that expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants