Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .pyi files #34496

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove .pyi files #34496

wants to merge 2 commits into from

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Feb 26, 2025

What does this PR do?

Remove .pyi files

Motivation

These files contains type hints for IDE. They are not used at runtime so we don't need to ship them.

Credits to @alopezz for the idea.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 26, 2025
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Feb 26, 2025
@FlorentClarret FlorentClarret force-pushed the florentclarret/pyi-files branch from 6967596 to 519f2be Compare February 26, 2025 19:24
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025

[Fast Unit Tests Report]

On pipeline 57124250 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025

Uncompressed package size comparison

Comparison with ancestor 5d5b9ce7826bb2e6d08a8e5596df7b9dab5ddc61

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.05MB 62.05MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.12MB 62.12MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.12MB 62.12MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.29MB 59.29MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.36MB 59.36MB 0.50MB
datadog-agent-aarch64-rpm -2.85MB 815.90MB 818.75MB 0.50MB
datadog-agent-x86_64-rpm -2.85MB 824.95MB 827.80MB 0.50MB
datadog-agent-x86_64-suse -2.85MB 824.95MB 827.80MB 0.50MB
datadog-agent-amd64-deb -2.85MB 815.15MB 818.00MB 0.50MB
datadog-agent-arm64-deb -2.85MB 806.12MB 808.97MB 0.50MB
datadog-heroku-agent-amd64-deb -2.85MB 440.56MB 443.42MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 26, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 788.84MiB 801.8MiB 192.26MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.22MiB 793.14MiB 174.57MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 788.9MiB 801.79MiB 194.4MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.28MiB 793.09MiB 175.87MiB 186.44MiB
static_quality_gate_agent_suse_amd64 788.91MiB 801.81MiB 194.4MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.27MiB 793.14MiB 175.87MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.28MiB 46.27MiB 8.49MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.25MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.62MiB 66.4MiB 12.83MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.25MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.62MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.25MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.54MiB 886.12MiB 293.85MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.19MiB 900.79MiB 280.1MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 368.93MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.2MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.82MiB 55.78MiB 17.28MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.45MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.96MiB 274.78MiB 106.35MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.92MiB 290.82MiB 101.18MiB 111.12MiB

Copy link

cit-pr-commenter bot commented Feb 26, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c2cec82b-a869-4ab7-b1c5-ad1b8105036f

Baseline: 5d5b9ce
Comparison: 3c6dee2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.54 [-1.37, +4.46] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.19 [-0.77, +1.16] 1 Logs
file_tree memory utilization +0.12 [+0.07, +0.18] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.11 [-0.35, +0.57] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.76, +0.82] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.78, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.86, +0.88] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.27, +0.29] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.04] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.85, +0.85] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.63, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.67, +0.67] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.81, +0.72] 1 Logs
quality_gate_idle_all_features memory utilization -0.42 [-0.48, -0.37] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.51 [-0.56, -0.46] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.17 [-1.23, -1.11] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant