RUMM-2050 fix code review comments

Author: xgouchet

README.md

@@ -55,7 +55,7 @@ config.sampleRate = 80
 // Optional: set the reported service name (by default, it'll use the package name / bundleIdentifier of your Android / iOS app respectively)
 config.serviceName = "com.example.reactnative"
 // Optional: let the SDK print internal logs (above or equal to the provided level. Default = undefined (meaning no logs))
-configuration.verbosity = SdkVerbosity.WARN
+config.verbosity = SdkVerbosity.WARN
 
 await DdSdkReactNative.initialize(config)
 

packages/core/README.md

@@ -51,7 +51,7 @@ config.sampleRate = 80
 // Optional: set the reported service name (by default, it'll use the package name / bundleIdentifier of your Android / iOS app respectively)
 config.serviceName = "com.example.reactnative"
 // Optional: let the SDK print internal logs (above or equal to the provided level. Default = undefined (meaning no logs))
-configuration.verbosity = SdkVerbosity.WARN
+config.verbosity = SdkVerbosity.WARN
 
 await DdSdkReactNative.initialize(config)
 

packages/core/src/DdSdkReactNative.tsx

@@ -115,7 +115,7 @@ export class DdSdkReactNative {
      */
     // eslint-disable-next-line @typescript-eslint/ban-types
     static setAttributes(attributes: object): Promise<void> {
-        InternalLog.log("Setting attributes " +  JSON.stringify(attributes), SdkVerbosity.DEBUG);
+        InternalLog.log("Setting attributes " + JSON.stringify(attributes), SdkVerbosity.DEBUG);
         return DdSdk.setAttributes(attributes)
     }
 
@@ -126,7 +126,7 @@ export class DdSdkReactNative {
      */
     // eslint-disable-next-line @typescript-eslint/ban-types
     static setUser(user: object): Promise<void> {
-        InternalLog.log("Setting user " +  JSON.stringify(user), SdkVerbosity.DEBUG);
+        InternalLog.log("Setting user " + JSON.stringify(user), SdkVerbosity.DEBUG);
         return DdSdk.setUser(user)
     }
 
@@ -136,7 +136,7 @@ export class DdSdkReactNative {
      * @returns a Promise.
      */
     static setTrackingConsent(consent: TrackingConsent): Promise<void> {
-        InternalLog.log("Setting consent " +  consent, SdkVerbosity.DEBUG);
+        InternalLog.log("Setting consent " + consent, SdkVerbosity.DEBUG);
         return DdSdk.setTrackingConsent(consent)
     }
 

packages/core/src/InternalLog.tsx

@@ -8,39 +8,41 @@ import {SdkVerbosity} from './SdkVerbosity'
 
 export class InternalLog {
 
+    private static levelMap = new Map<SdkVerbosity, number>([
+        [SdkVerbosity.DEBUG, 1],
+        [SdkVerbosity.INFO, 2],
+        [SdkVerbosity.WARN, 3],
+        [SdkVerbosity.ERROR, 4]
+    ]);
+
     public static verbosity: SdkVerbosity|undefined = undefined
 
-    // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
-    public static log (message: any, verbosity: SdkVerbosity) {
+    public static log (message: string, verbosity: SdkVerbosity): void {
+        if (InternalLog.verbosity === undefined) {
+            return;
+        }
+        const requiredLevel = InternalLog.levelMap.get(verbosity);
+        const allowedLevel = InternalLog.levelMap.get(InternalLog.verbosity);
+        if (allowedLevel === undefined || requiredLevel === undefined) {
+            return;
+        }
         const prefixedMessage = "DATADOG: " + message
-        if (verbosity == SdkVerbosity.ERROR && (
-                (InternalLog.verbosity == SdkVerbosity.ERROR) ||
-                (InternalLog.verbosity == SdkVerbosity.WARN) ||
-                (InternalLog.verbosity == SdkVerbosity.INFO) ||
-                (InternalLog.verbosity == SdkVerbosity.DEBUG)
-        )) {
+        if (verbosity == SdkVerbosity.ERROR && (requiredLevel >= allowedLevel)) {
             console.error(prefixedMessage)
         }
 
-        if (verbosity == SdkVerbosity.WARN && (
-                (InternalLog.verbosity == SdkVerbosity.WARN) ||
-                (InternalLog.verbosity == SdkVerbosity.INFO) ||
-                (InternalLog.verbosity == SdkVerbosity.DEBUG)
-        )) {
+        if (verbosity == SdkVerbosity.WARN && (requiredLevel >= allowedLevel)) {
             console.warn(prefixedMessage)
         }
 
-        if (verbosity == SdkVerbosity.INFO && (
-                (InternalLog.verbosity == SdkVerbosity.INFO) ||
-                (InternalLog.verbosity == SdkVerbosity.DEBUG)
-        )) {
-            console.log(prefixedMessage)
+        if (verbosity == SdkVerbosity.INFO && (requiredLevel >= allowedLevel)) {
+            console.info(prefixedMessage)
         }
 
-        if (verbosity == SdkVerbosity.DEBUG && (
-                (InternalLog.verbosity == SdkVerbosity.DEBUG)
-        )) {
-            console.log(prefixedMessage)
+        if (verbosity == SdkVerbosity.DEBUG && (requiredLevel >= allowedLevel)) {
+            console.debug(prefixedMessage)
         }
     }
+
+
 }

packages/core/src/SdkVerbosity.tsx

@@ -5,7 +5,7 @@
  */
 
 /**
- * Enum specifying possible consent options for DD SDK.
+ * Enum specifying possible log levels for DD SDK.
  */
 export enum SdkVerbosity {
     DEBUG = "debug",