Skip to content

Commit bb81d2f

Browse files
Merge pull request #827 from DataDog/xgouchet/xcode_bug
Fix bug with XCode
2 parents 9806dca + 560c8a0 commit bb81d2f

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.gitlab-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ test:native-ios:
9393
script:
9494
- yarn
9595
- (cd example/ios && pod install --repo-update)
96-
- set -o pipefail && CODE_SIGNING_REQUIRED=NO && xcodebuild -workspace example/ios/DdSdkReactNativeExample.xcworkspace -scheme DatadogSDKReactNative test -destination "platform=iOS Simulator,OS=16.0,name=iPhone 14 Pro Max" | xcbeautify
96+
- set -o pipefail && CODE_SIGNING_REQUIRED=NO && CODE_SIGNING_ALLOWED=NO && xcodebuild -workspace example/ios/DdSdkReactNativeExample.xcworkspace -scheme DatadogSDKReactNative test -destination "platform=iOS Simulator,OS=17.4,name=iPhone 15 Pro Max" | xcbeautify
9797

9898
test:native-ios-sr:
9999
tags: [ "macos:sonoma", "specific:true" ]
@@ -102,4 +102,4 @@ test:native-ios-sr:
102102
script:
103103
- yarn
104104
- (cd example/ios && pod install --repo-update)
105-
- set -o pipefail && CODE_SIGNING_REQUIRED=NO && xcodebuild -workspace example/ios/DdSdkReactNativeExample.xcworkspace -scheme DatadogSDKReactNativeSessionReplay test -destination "platform=iOS Simulator,OS=16.0,name=iPhone 14 Pro Max" | xcbeautify
105+
- set -o pipefail && CODE_SIGNING_REQUIRED=NO && CODE_SIGNING_ALLOWED=NO && xcodebuild -workspace example/ios/DdSdkReactNativeExample.xcworkspace -scheme DatadogSDKReactNativeSessionReplay test -destination "platform=iOS Simulator,OS=17.4,name=iPhone 15 Pro Max" | xcbeautify

example/ios/Podfile

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,16 @@ target 'ddSdkReactnativeExample' do
4040
datadog_sdk_target = installer.pods_project.targets.detect {|t| ["DatadogCore", "DatadogRUM", "DatadogLogs", "DatadogInternal", "DatadogTrace", "DatadogCrashReporting"].include?(t.name) }
4141
datadog_sdk_target.build_configurations.each do |config|
4242
config.build_settings['SWIFT_ACTIVE_COMPILATION_CONDITIONS'] = '$(inherited) DD_SDK_COMPILED_FOR_TESTING'
43-
end
43+
end
44+
45+
# Disable code signing for Unit-Tests
46+
installer.pods_project.targets.each do |target|
47+
if target.name == 'DatadogSDKReactNative-Unit-Tests'
48+
target.build_configurations.each do |config|
49+
config.build_settings['CODE_SIGNING_REQUIRED'] = 'NO'
50+
config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
51+
end
52+
end
53+
end
4454
end
4555
end

0 commit comments

Comments
 (0)