Commit 1a43844
committed
ci(py-315): prune cp315 wheels at every publication choke point
PR #19880 filtered cp315 out of the PyPI upload only, on the stated premise that
the other destination was "internal S3 and the private prerelease index". That is
wrong: s3://dd-trace-py-builds is anonymously readable and listable and is
registered in DataDog/cloud-inventory as a "Public bucket to host dev builds of
dd-trace-py from GitLab to share with customers". The pipeline republished cp315
wheels to main/ on 2026-08-27, so the leak was live, not historical.
Three mechanisms publish a ddtrace wheel outside the pipeline: twine to PyPI,
aws s3 cp to that bucket, and adms to pypi-private-prereleases. All three now call
.gitlab/scripts/prune-unsupported-wheels.sh first, which holds the withheld ABI
tags in one place. Putting it inside upload-wheels-to-s3.sh covers every S3 caller
and every index suffix, including "upload serverless", which no filter reached
before.
The PyPI-side shell in release.yml reverts to the pre-filter form plus one prune
call, per review feedback: with cp315 gone from the "ddtrace package" artifact,
twine check no longer needs a hand-built file list.
tests/internal/test_unsupported_wheel_pruning.py replaces the PyPI-specific test.
It pins the prune behaviour and asserts that every file under .gitlab/ running a
publish command also calls the prune script, so a new upload path cannot silently
reintroduce cp315.1 parent 959c3bc commit 1a43844
6 files changed
Lines changed: 354 additions & 257 deletions
File tree
- .gitlab
- scripts
- tests/internal
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
| 110 | + | |
109 | 111 | | |
110 | 112 | | |
111 | 113 | | |
| |||
226 | 228 | | |
227 | 229 | | |
228 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
229 | 234 | | |
230 | 235 | | |
231 | 236 | | |
| |||
497 | 502 | | |
498 | 503 | | |
499 | 504 | | |
| 505 | + | |
| 506 | + | |
500 | 507 | | |
501 | 508 | | |
502 | 509 | | |
| |||
507 | 514 | | |
508 | 515 | | |
509 | 516 | | |
| 517 | + | |
510 | 518 | | |
511 | 519 | | |
512 | 520 | | |
| |||
515 | 523 | | |
516 | 524 | | |
517 | 525 | | |
| 526 | + | |
518 | 527 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
40 | 27 | | |
41 | 28 | | |
42 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
21 | 31 | | |
22 | 32 | | |
23 | 33 | | |
| |||
This file was deleted.
0 commit comments