Skip to content

Commit 35d0900

Browse files
committed
First pass respond comments
1 parent 0ede87a commit 35d0900

File tree

8 files changed

+121
-2115
lines changed

8 files changed

+121
-2115
lines changed

ddtrace/internal/core/crashtracking.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@
1919

2020
is_available = True
2121
try:
22-
from ddtrace.internal.native._native import CallbackResult
2322
from ddtrace.internal.native._native import CrashtrackerConfiguration
2423
from ddtrace.internal.native._native import CrashtrackerMetadata
2524
from ddtrace.internal.native._native import CrashtrackerReceiverConfig
2625
from ddtrace.internal.native._native import CrashtrackerStatus
2726
from ddtrace.internal.native._native import StacktraceCollection
2827
from ddtrace.internal.native._native import crashtracker_init
2928
from ddtrace.internal.native._native import crashtracker_on_fork
30-
from ddtrace.internal.native._native import crashtracker_register_native_runtime_callback
3129
from ddtrace.internal.native._native import crashtracker_status
3230
except ImportError:
3331
is_available = False
@@ -157,12 +155,6 @@ def start(additional_tags: Optional[Dict[str, str]] = None) -> bool:
157155

158156
crashtracker_init(config, receiver_config, metadata)
159157

160-
if crashtracker_config.stacktrace_resolver is not None and crashtracker_config.stacktrace_resolver != "none":
161-
result = crashtracker_register_native_runtime_callback()
162-
# Shouldn't block on this, but log an error if it fails
163-
if result != CallbackResult.Ok:
164-
print(f"Failed to register runtime callback: {result}", file=sys.stderr)
165-
166158
def crashtracker_fork_handler():
167159
# We recreate the args here mainly to pass updated runtime_id after
168160
# fork

ddtrace/internal/native/_native.pyi

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,6 @@ class CrashtrackerStatus:
9595
Initialized: "CrashtrackerStatus"
9696
FailedToInitialize: "CrashtrackerStatus"
9797

98-
class CallbackResult:
99-
Ok: "CallbackResult"
100-
UnknownError: "CallbackResult"
101-
10298
def crashtracker_init(
10399
config: CrashtrackerConfiguration, receiver_config: CrashtrackerReceiverConfig, metadata: CrashtrackerMetadata
104100
) -> None: ...
@@ -107,7 +103,6 @@ def crashtracker_on_fork(
107103
) -> None: ...
108104
def crashtracker_status() -> CrashtrackerStatus: ...
109105
def crashtracker_receiver() -> None: ...
110-
def crashtracker_register_native_runtime_callback() -> CallbackResult: ...
111106

112107
class PyTracerMetadata:
113108
"""

releasenotes/notes/crashtracker-emit-runtime-stacktrace-45815b6eecdc317b.yaml

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)