Use ddconfig for runtime stacktrace emission

Author: gyuheon0h

ddtrace/internal/core/crashtracking.py

@@ -153,6 +153,10 @@ def start(additional_tags: Optional[Dict[str, str]] = None) -> bool:
             print("Failed to start crashtracker: failed to construct crashtracker configuration", file=sys.stderr)
             return False
 
+        # crashtracker_init(
+        #     config, receiver_config, metadata, emit_runtime_stacks=crashtracker_config.emit_runtime_stacks
+        # )
+
         crashtracker_init(config, receiver_config, metadata)
 
         def crashtracker_fork_handler():

ddtrace/internal/native/_native.pyi

@@ -96,7 +96,11 @@ class CrashtrackerStatus:
     FailedToInitialize: "CrashtrackerStatus"
 
 def crashtracker_init(
-    config: CrashtrackerConfiguration, receiver_config: CrashtrackerReceiverConfig, metadata: CrashtrackerMetadata
+    config: CrashtrackerConfiguration,
+    receiver_config: CrashtrackerReceiverConfig,
+    metadata: CrashtrackerMetadata,
+    # TODO: Add this back in post Code Freeze (need to update config registry)
+    # emit_runtime_stacks: bool,
 ) -> None: ...
 def crashtracker_on_fork(
     config: CrashtrackerConfiguration, receiver_config: CrashtrackerReceiverConfig, metadata: CrashtrackerMetadata

ddtrace/internal/settings/crashtracker.py

@@ -121,6 +121,15 @@ class CrashtrackingConfig(DDConfig):
         help="Whether to wait for the crashtracking receiver",
     )
 
+    # TODO: Add this back in post Code Freeze (need to update config registry)
+    # emit_runtime_stacks = DDConfig.v(
+    #     bool,
+    #     "emit_runtime_stacks",
+    #     default=False,
+    #     help_type="Boolean",
+    #     help="Whether to emit runtime stacks during a crash.",
+    # )
+
 
 config = CrashtrackingConfig()
 report_configuration(config)

src/native/crashtracker.rs

@@ -24,6 +24,8 @@ type PyDumpTracebackThreadsFn = unsafe extern "C" fn(
 static mut DUMP_TRACEBACK_FN: Option<PyDumpTracebackThreadsFn> = None;
 static DUMP_TRACEBACK_INIT: std::sync::Once = std::sync::Once::new();
 
+// We define these raw system calls here to be used within signal handler context.
+// These direct C functions are preferred over going through Rust wrappers
 extern "C" {
     fn pipe(pipefd: *mut [c_int; 2]) -> c_int;
     fn read(fd: c_int, buf: *mut c_void, count: usize) -> isize;
@@ -245,6 +247,8 @@ pub fn crashtracker_init<'py>(
     mut config: PyRefMut<'py, CrashtrackerConfigurationPy>,
     mut receiver_config: PyRefMut<'py, CrashtrackerReceiverConfigPy>,
     mut metadata: PyRefMut<'py, CrashtrackerMetadataPy>,
+    // TODO: Add this back in post Code Freeze (need to update config registry)
+    // emit_runtime_stacks: bool,
 ) -> anyhow::Result<()> {
     INIT.call_once(|| {
         let (config_opt, receiver_config_opt, metadata_opt) = (
@@ -256,8 +260,8 @@ pub fn crashtracker_init<'py>(
         if let (Some(config), Some(receiver_config), Some(metadata)) =
             (config_opt, receiver_config_opt, metadata_opt)
         {
-            let runtime_stacktrace_enabled = std::env::var("DD_CRASHTRACKER_EMIT_RUNTIME_STACKS").unwrap_or_default();
-            if runtime_stacktrace_enabled == "true" || runtime_stacktrace_enabled == "1" {
+            let emit_runtime_stacks = std::env::var("DD_CRASHTRACKING_EMIT_RUNTIME_STACKS").unwrap_or("false".to_string());
+            if emit_runtime_stacks {
                 unsafe {
                     init_dump_traceback_fn();
                 }

tests/internal/crashtracker/test_crashtracker.py

@@ -460,7 +460,7 @@ def test_crashtracker_tags_required():
 def test_crashtracker_runtime_stacktrace_required(run_python_code_in_subprocess):
     with utils.with_test_agent() as client:
         env = os.environ.copy()
-        env["DD_CRASHTRACKER_EMIT_RUNTIME_STACKS"] = "true"
+        env["DD_CRASHTRACKING_EMIT_RUNTIME_STACKS"] = "true"
         stdout, stderr, exitcode, _ = run_python_code_in_subprocess(auto_code, env=env)
 
         # Check for expected exit condition