ci(profiling): add a clang-tidy check

Author: KowalskiThomas

.gitlab/native.yml

@@ -21,3 +21,24 @@ include:
       echo -e "\e[0Ksection_start:`date +%s`:cargo_test[collapsed=true]\r\e[0Kcargo test"
       cargo test --no-fail-fast --locked
       echo -e "\e[0Ksection_end:`date +%s`:cargo_test\r\e[0K"
+
+"clang-tidy profiling":
+  stage: tests
+  image: registry.ddbuild.io/images/mirror/ubuntu:25.04
+  tags: ["arch:amd64"]
+  timeout: 20m
+  needs: []
+  before_script:
+    - apt-get update && apt-get install -y clang clang-tidy cmake bc python3 python3-pip python3-venv curl
+    - curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y
+    - source "$HOME/.cargo/env"
+    - python3 -m venv /tmp/venv
+    - source /tmp/venv/bin/activate
+    - python3 -m pip install setuptools wheel cmake setuptools_rust cython wrapt bytecode envier lz4 grpcio protobuf
+  script:
+    - |
+      echo -e "\e[0Ksection_start:`date +%s`:clang_tidy_build[collapsed=true]\r\e[0Kclang-tidy on profiling C++ code"
+      source /tmp/venv/bin/activate
+      python3 -c "import cython; print(cython.__file__)"
+      ddtrace/internal/datadog/profiling/build_standalone.sh --clangtidy Debug all
+      echo -e "\e[0Ksection_end:`date +%s`:clang_tidy_build\r\e[0K"

ddtrace/internal/datadog/profiling/build_standalone.sh

@@ -103,7 +103,7 @@ cmake_args=(
   -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
   -DCMAKE_VERBOSE_MAKEFILE=ON
   -DLIB_INSTALL_DIR=$(realpath $MY_DIR)/lib
-  -DPython3_ROOT_DIR=$(python3 -c "import sysconfig; print(sysconfig.get_config_var('prefix'))")
+  -DPython3_ROOT_DIR=$(python3 -c "import sys; print(sys.prefix)")
   -DNATIVE_EXTENSION_LOCATION=$(realpath $MY_DIR)/../../native
   -DEXTENSION_SUFFIX=$(python3 -c "import sysconfig; print(sysconfig.get_config_var('EXT_SUFFIX'))")
 )

ddtrace/internal/datadog/profiling/stack/CMakeLists.txt

@@ -39,6 +39,7 @@ set_target_properties(
 include(FetchContent)
 include(AnalysisFunc)
 include(FindCppcheck)
+include(FindClangtidy)
 
 find_package(Python3 COMPONENTS Interpreter Development)
 
@@ -71,6 +72,9 @@ add_cppcheck_target(
     SRC
     ${CMAKE_CURRENT_SOURCE_DIR}/src)
 
+# Static analysis
+add_clangtidy_target(${EXTENSION_NAME})
+
 # Never build with native unwinding, since this is not currently used
 target_compile_definitions(${EXTENSION_NAME} PRIVATE UNWIND_NATIVE_DISABLE)