Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falcon ASGI support #10446

Open
lattwood opened this issue Aug 29, 2024 · 1 comment
Open

Falcon ASGI support #10446

lattwood opened this issue Aug 29, 2024 · 1 comment

Comments

@lattwood
Copy link

It appears as though the current version of the Falcon integration only has sync methods.

https://github.com/DataDog/dd-trace-py/blob/16f2960b01178da325dec61c67ac3dd50137573e/ddtrace/contrib/internal/falcon/middleware.py

According to the Falcon docs, in order to support ASGI apps as well as WSGI apps, there needs to be *_async postfix methods in the TraceMiddleware.

https://falcon.readthedocs.io/en/stable/api/middleware.html

@emmettbutler
Copy link
Collaborator

Thanks for pointing this out, @lattwood. We'll add it to our backlog of feature requests and it will be included in a future prioritization pass.

cc @mabdinur

@emmettbutler emmettbutler added changelog/no-changelog A changelog entry is not required for this PR. feature-request and removed changelog/no-changelog A changelog entry is not required for this PR. labels Aug 29, 2024
@emmettbutler emmettbutler changed the title Falcon integration only supports WSGI apps Falcon ASGI support Aug 29, 2024
@github-actions github-actions bot added the stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants