Address review findings on component.rb

Six small changes flagged in review on the Component class:

- build: `unless environment_supported?(symdb_logger) ... return nil end`
  collapsed to guard-clause `return nil unless environment_supported?(...)`,
  with a note that the helper logs the specific reason internally.
- build: compound `unless settings.remote&.enabled || ... force_upload`
  flipped to `if !A && !B` (DeMorgan) — easier to read.
- shutdown!: removed standalone `# @api private` marker before `private`
  keyword (redundant; the keyword already enforces visibility).
- scheduler_loop: added a comment explaining what `should_fire = true`
  means (debounce deadline elapsed; extract_and_upload runs once after
  the mutex is released).
- scheduler_loop: removed the steep:ignore:start/:end block around the
  mutex section. NOTE: removal is unverified locally because the libdatadog
  version mismatch blocks Steep from running here; CI will surface a
  regression if removal isn't safe.
- extract_and_upload: moved `extraction_duration` and `targetable_count`
  calculations inside the `@logger.debug` block so the work is skipped
  when debug logging is off (the latter iterates the scope tree).

Co-Authored-By: Claude <noreply@anthropic.com>

Author: p-ddsign

lib/datadog/symbol_database/component.rb

@@ -91,12 +91,11 @@ def self.build(settings, agent_settings, logger)
         # Symbol database requires MRI Ruby 2.6+.
         # Configuration accessors (settings.symbol_database.*) remain available on all
         # platforms — only the component (upload) is disabled on unsupported engines/versions.
-        unless environment_supported?(symdb_logger)
-          return nil
-        end
+        # environment_supported? logs the specific reason (engine or version) internally.
+        return nil unless environment_supported?(symdb_logger)
 
         # Requires remote config (unless force mode)
-        unless settings.remote&.enabled || settings.symbol_database.internal.force_upload
+        if !settings.remote&.enabled && !settings.symbol_database.internal.force_upload
           symdb_logger.debug("symdb: remote config not available and force_upload not set, skipping")
           return nil
         end
@@ -255,7 +254,6 @@ def shutdown!
         @scope_batcher.shutdown
       end
 
-      # @api private
       private
 
       # Check whether the runtime environment supports symbol database upload.
@@ -291,9 +289,10 @@ def ensure_scheduler_thread
       # @return [void]
       def scheduler_loop
         loop do
+          # should_fire = true means the debounce deadline elapsed without further
+          # signals; extract_and_upload runs once after the mutex is released.
           should_fire = false
 
-          # steep:ignore:start
           @scheduler_mutex.synchronize do
             return if @shutdown
             return if Component.uploaded_this_process?
@@ -317,7 +316,6 @@ def scheduler_loop
               end
             end
           end
-          # steep:ignore:end
 
           # `next` inside `synchronize` only exits the synchronize block — not the
           # surrounding loop. Use an explicit flag so the loop only fires
@@ -357,9 +355,11 @@ def extract_and_upload
             log_scope_tree(scope, 0)
           end
 
-          extraction_duration = Datadog::Core::Utils::Time.get_time - start_time
-          targetable_count = count_targetable_methods(file_scopes)
-          @logger.debug { "symdb: extracted #{extracted_count} scopes (#{targetable_count} methods with targetable lines) in #{'%.2f' % extraction_duration}s" }
+          @logger.debug do
+            extraction_duration = Datadog::Core::Utils::Time.get_time - start_time
+            targetable_count = count_targetable_methods(file_scopes)
+            "symdb: extracted #{extracted_count} scopes (#{targetable_count} methods with targetable lines) in #{'%.2f' % extraction_duration}s"
+          end
 
           # Flush any remaining scopes (triggers upload)
           @scope_batcher.flush