Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/en/tracing/trace_collection/open_standards: warn about gateway deploys #15206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Sep 5, 2022

This change ensures to underline the fact that Datadog is only compatible with Gateway deployments where an agent is deployed on each application host, by adding a warning that looks like this:

Screenshot 2022-09-05 at 15 43 51

@gbbr gbbr requested a review from a team as a code owner September 5, 2022 12:45
@gbbr gbbr requested a review from dineshg13 September 5, 2022 12:45
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@pj-datadog pj-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this note and it should not be merged for the following reasons:

  1. It will deter potential OTel customers from even trying Datadog
  2. Gateway is the most common way to use OTel collector for OTel customers
  3. We should look into how we can solve this problem rather than calling it out

@@ -200,6 +200,10 @@ To learn more about configuring your application, read the [Application Configur

For Gateway deployments:

<div class="alert alert-warning">
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add table explaining, what features they get with gateway and with agent. It is not that we are incompatible but they wouldn't have a good experience esp around host metrics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a diagram explaining each mode would also be good to add.

Copy link
Contributor Author

@gbbr gbbr Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have the most background here and proposed this change to begin with, I will let you take over this PR.

Is that ok with you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure . Will take this forward.

@@ -200,6 +200,10 @@ To learn more about configuring your application, read the [Application Configur

For Gateway deployments:

<div class="alert alert-warning">
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience.
Datadog is incompatible with Gateway deployments, which do not have a Collector agent deployed running on each application host. Such a set up results in a broken product experience.

@hestonhoffman
Copy link
Contributor

@dineshg13 This PR has been open for a while and it looks like you took over ownership. Are you still working on this?

@hestonhoffman hestonhoffman added salmon_curry stale for PRs that are outdated and have merge conflicts labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
salmon_curry stale for PRs that are outdated and have merge conflicts tracing Content changed in the tracing folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants