-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content/en/tracing/trace_collection/open_standards: warn about gateway deploys #15206
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with this note and it should not be merged for the following reasons:
- It will deter potential OTel customers from even trying Datadog
- Gateway is the most common way to use OTel collector for OTel customers
- We should look into how we can solve this problem rather than calling it out
@@ -200,6 +200,10 @@ To learn more about configuring your application, read the [Application Configur | |||
|
|||
For Gateway deployments: | |||
|
|||
<div class="alert alert-warning"> | |||
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add table explaining, what features they get with gateway and with agent. It is not that we are incompatible but they wouldn't have a good experience esp around host metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a diagram explaining each mode would also be good to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you have the most background here and proposed this change to begin with, I will let you take over this PR.
Is that ok with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure . Will take this forward.
@@ -200,6 +200,10 @@ To learn more about configuring your application, read the [Application Configur | |||
|
|||
For Gateway deployments: | |||
|
|||
<div class="alert alert-warning"> | |||
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Datadog is incompatible with Gateway deployments which do not have a Collector agent deployed running on each application host. Such a set up will result in a broken product exprience. | |
Datadog is incompatible with Gateway deployments, which do not have a Collector agent deployed running on each application host. Such a set up results in a broken product experience. |
@dineshg13 This PR has been open for a while and it looks like you took over ownership. Are you still working on this? |
This change ensures to underline the fact that Datadog is only compatible with Gateway deployments where an agent is deployed on each application host, by adding a warning that looks like this: