Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usage metering consolidate #15342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

usage metering consolidate #15342

wants to merge 2 commits into from

Conversation

davidejones
Copy link
Member

What does this PR do?

This PR:

  • Removes from the usage metering api nav endpoints by specific products e.g Get hourly usage for lambda
  • Adds links to these specific endpoints under a v1 tab in get hourly usage by product family

Motivation

API discussions

Preview

View the v1 and v2 tabs for get hourly usage by product family
https://docs-staging.datadoghq.com/david.jones/metric-usage-migrate/api/latest/usage-metering/#get-hourly-usage-by-product-family

Check other endpoints in other places operate as normal.

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@davidejones davidejones requested review from a team as code owners September 22, 2022 09:40
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Sep 22, 2022
hestonhoffman
hestonhoffman approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidejones davidejones added the Do Not Merge Just do not merge this PR :) label Sep 23, 2022
@davidejones
Copy link
Member Author

Just throwing a do not merge on here for now to give api channel a chance for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Do Not Merge Just do not merge this PR :) salmon_curry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidejones @hestonhoffman