-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB-2754 - format link fixes #15544
base: master
Are you sure you want to change the base?
WEB-2754 - format link fixes #15544
Conversation
f192cbf
to
0756b5c
Compare
49ad7b1
to
ec0620e
Compare
46e7cf5
to
31b5b50
Compare
Hi David, I ran this on a test file and tried to break it and it looks like it's working really well! |
@davidejones I just tried this on a file I've been writing, and while it doesn't throw an error like the old script did (I think it's cos I'm using single line code-blocks), it doesn't renumber the references. Here's the file for reference |
@hestonhoffman So generally i've tried to make the script avoid re-ordering where possible for 2 reasons.
I can change this though, would docs prefer the same behavior as before? |
@davidejones Yeah, that makes sense. I prefer this behavior. It should prevent the issue where merging master into a feature bunch pulls a bunch of unrelated changes into the PR |
e56fd16
to
36b3b42
Compare
bb5854c
to
e685757
Compare
8f8ee08
to
114ed30
Compare
@@ -1,6 +1,6 @@ | |||
--- | |||
- config: | |||
cache_enabled: true | |||
cache_enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be changed back for preview? @davidejones
114ed30
to
003262d
Compare
What does this PR do?
site-region can also have its own link scope.As this wasn't being accounted for it would leak into the "main" section causing the format link to say there are duplicates
EDIT:
This PR:
Motivation
https://datadoghq.atlassian.net/browse/WEB-2754
Preview
TestingLocally i tested the following file
Trying on all files with something likeHowever we should test multiple file changes and see how the content changes.EDIT:
We should now just test that integrations are displaying as intended on the preview:
https://docs-staging.datadoghq.com/david.jones/format-link-fixes/integrations/
Additional Notes
Reviewer checklist