-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the library version form /healthcheck response #2799
Comments
7 tasks
cbeauchesne
added a commit
that referenced
this issue
Aug 22, 2024
cbeauchesne
added a commit
that referenced
this issue
Aug 26, 2024
[python] Use healthcheck to get info #2799
cbeauchesne
changed the title
Get the library version form healtcheck response
Get the library version form /healthcheck response
Aug 30, 2024
cbeauchesne
added a commit
that referenced
this issue
Sep 2, 2024
7 tasks
cbeauchesne
added a commit
that referenced
this issue
Sep 2, 2024
mtoffl01
pushed a commit
that referenced
this issue
Sep 11, 2024
cbeauchesne
added a commit
that referenced
this issue
Oct 7, 2024
cbeauchesne
added a commit
that referenced
this issue
Oct 9, 2024
cbeauchesne
added a commit
that referenced
this issue
Oct 9, 2024
cbeauchesne
added a commit
that referenced
this issue
Oct 9, 2024
cbeauchesne
added a commit
that referenced
this issue
Oct 9, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The initial solution to get library version was, at build step :
docker run weblog cat SYSTEM_TESTS_LIBRARY_VERSION
docker build --arg version=$VERSION
This mechanism offers one great advantage : for a given language, only one file must be adapted :
install_ddtrace.sh
script.But it comes with some disadvantages :
docker run cat
is not freeThe disadvantage 3 has been the main motivation from getting away from the existing solution, for the nodejs library who wanted to be able to mount directly their sources at the run step.
The target solution is to get this version thanks to the
healthcheck
requests :At the non-negligible cost of requiring all weblogs to be adapted.
The text was updated successfully, but these errors were encountered: