Skip to content

python_lambda: allow for library target branches and detect arch in install script #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbeauchesne merged 12 commits into from
Dec 10, 2025
Merged

python_lambda: allow for library target branches and detect arch in install script #5807

cbeauchesne merged 12 commits into from
Dec 10, 2025

Conversation

@florentinl
Copy link
Contributor

@florentinl florentinl commented Dec 2, 2025 •
edited
Loading

APPSEC-60129

Motivation

  • To be able to run tests locally on an arm64 laptop without having to modify the install_datadog_lambda.sh script
  • To use the library target branch feature, for testing

Changes

  • Parse the current architecture to fetch the correct artifact
  • Parse library target branches for python_lambda as well

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

.github/actions/get_target_branch/action.yaml                           @DataDog/system-tests-core
utils/build/docker/python_lambda/install_datadog_lambda.sh              @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core
utils/scripts/load-binary.sh                                            @DataDog/system-tests-core

@florentinl florentinl force-pushed the florentin.labelle/make-install-datadog-lambda-arch-agnostic branch 2 times, most recently from 8dbb65e to 16e41ae Compare December 2, 2025 14:45
@florentinl florentinl changed the title [python_lambda]: download datadog-lambda-python in an arch agnostic way [[email protected]/delete-me/test]: download datadog-lambda-python in an arch agnostic way Dec 2, 2025
@florentinl florentinl force-pushed the florentin.labelle/make-install-datadog-lambda-arch-agnostic branch from 16e41ae to f0c3cc7 Compare December 2, 2025 14:48
@florentinl florentinl changed the title [[email protected]/delete-me/test]: download datadog-lambda-python in an arch agnostic way [[email protected]/APPSEC-60129/publish-layers-for-any-ddtrace-branch]: download datadog-lambda-python in an arch agnostic way Dec 2, 2025
@florentinl florentinl changed the title [[email protected]/APPSEC-60129/publish-layers-for-any-ddtrace-branch]: download datadog-lambda-python in an arch agnostic way [[email protected]/APPSEC-60129/publish-layers-for-any-ddtrace-branch]: allow for library target branches Dec 2, 2025
@florentinl florentinl changed the title [[email protected]/APPSEC-60129/publish-layers-for-any-ddtrace-branch]: allow for library target branches python_lambda: allow for library target branches Dec 2, 2025
@florentinl florentinl changed the title python_lambda: allow for library target branches python_lambda: detect arch in install script and allow for library target branches Dec 2, 2025
@florentinl florentinl force-pushed the florentin.labelle/make-install-datadog-lambda-arch-agnostic branch from ab681e4 to 26cb5bb Compare December 2, 2025 15:58
@florentinl florentinl changed the title python_lambda: detect arch in install script and allow for library target branches python_lambda: allow for library target branches and detect arch in install script Dec 3, 2025
@florentinl florentinl marked this pull request as ready for review December 8, 2025 13:13
@florentinl florentinl requested review from a team as code owners December 8, 2025 13:13
@florentinl florentinl requested review from vlad-scherbich and wantsui and removed request for a team December 8, 2025 13:13
@florentinl florentinl enabled auto-merge (squash) December 8, 2025 23:16
@cbeauchesne
Copy link
Collaborator

cbeauchesne commented Dec 10, 2025

Rebasing to fix the ruby error

@cbeauchesne cbeauchesne disabled auto-merge December 10, 2025 15:47
@cbeauchesne cbeauchesne merged commit 2862c6d into main Dec 10, 2025
2566 of 2599 checks passed
@cbeauchesne cbeauchesne deleted the florentin.labelle/make-install-datadog-lambda-arch-agnostic branch December 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@vlad-scherbich vlad-scherbich Awaiting requested review from vlad-scherbich vlad-scherbich is a code owner automatically assigned from DataDog/apm-python

@wantsui wantsui Awaiting requested review from wantsui wantsui is a code owner automatically assigned from DataDog/apm-python

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florentinl @cbeauchesne