Skip to content

add api10 test for redirection with status code analysis #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbeauchesne merged 6 commits into from
Dec 8, 2025
Merged

add api10 test for redirection with status code analysis #5831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9402cc7
add api10 test for redirection with status code analysis
christophe-papazian Dec 5, 2025
b5f0c1c
update manifests
christophe-papazian Dec 5, 2025
6d485cd
Merge branch 'main' into christophe-papazian/api10_redirection_status…
christophe-papazian Dec 5, 2025
c2f60de
python support
christophe-papazian Dec 8, 2025
1910180
Merge branch 'christophe-papazian/api10_redirection_status_code' of g…
christophe-papazian Dec 8, 2025
cafd5a1
Merge remote-tracking branch 'origin/main' into christophe-papazian/a…
christophe-papazian Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manifests/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ tests/:
Test_API10_downstream_request_tag: missing_feature
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: missing_feature
Test_API10_request_headers: missing_feature
Test_API10_request_method: missing_feature
Expand Down
1 change: 1 addition & 0 deletions manifests/golang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ tests/:
Test_API10_downstream_request_tag: v2.5.0-dev
Test_API10_downstream_ssrf_telemetry: v2.4.0
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: v2.4.0
Test_API10_request_headers: v2.4.0
Test_API10_request_method: v2.4.0
Expand Down
1 change: 1 addition & 0 deletions manifests/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ tests/:
vertx3: v1.54.0
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body:
'*': missing_feature
vertx3: v1.54.0
Expand Down
1 change: 1 addition & 0 deletions manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ tests/:
Test_API10_downstream_request_tag: missing_feature
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: missing_feature
Test_API10_request_headers: missing_feature
Test_API10_request_method: missing_feature
Expand Down
1 change: 1 addition & 0 deletions manifests/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ tests/:
Test_API10_downstream_request_tag: missing_feature
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: missing_feature
Test_API10_request_headers: missing_feature
Test_API10_request_method: missing_feature
Expand Down
1 change: 1 addition & 0 deletions manifests/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ tests/:
Test_API10_redirect:
'*': v3.18.0 (with urllib support)
'fastapi': v4.1.0 (with requests/urllib3 support)
Test_API10_redirect_status: v4.1.0
Test_API10_request_body:
'*': v3.14.0.rc
'fastapi': v3.15.0.dev (with requests support)
Expand Down
4 changes: 4 additions & 0 deletions manifests/python_lambda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ tests/:
rasp/:
test_api10.py:
Test_API10_all: v8.117.0.dev
Test_API10_downstream_request_tag: missing_feature
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: v8.117.0.dev
Test_API10_request_headers: v8.117.0.dev
Test_API10_request_method: v8.117.0.dev
Expand Down
1 change: 1 addition & 0 deletions manifests/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ tests/:
Test_API10_downstream_request_tag: missing_feature
Test_API10_downstream_ssrf_telemetry: missing_feature
Test_API10_redirect: missing_feature
Test_API10_redirect_status: missing_feature
Test_API10_request_body: missing_feature
Test_API10_request_headers: missing_feature
Test_API10_request_method: missing_feature
Expand Down
43 changes: 41 additions & 2 deletions tests/appsec/rasp/rasp_non_blocking_ruleset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"stack_trace"
]
},

{
"id": "rasp-930-100",
"name": "Local file inclusion exploit",
Expand Down Expand Up @@ -277,6 +276,46 @@
"on_match": [
"stack_trace"
]
}
},
{
"id": "api-010-100",
"name": "Monitor redirections to GET targets",
"enabled": true,
"tags": {
"type": "api10",
"category": "api_security",
"confidence": "0",
"module": "business-logic"
},
"conditions": [
{
"parameters": {
"inputs": [
{
"address": "server.io.net.response.status"
}
],
"list": [
"301",
"302"
]
},
"operator": "exact_match"
}
],
"transformers": [],
"output": {
"event": false,
"keep": true,
"attributes": {
"appsec.api.redirection.move_target": {
"address": "server.io.net.response.headers",
"key_path": [
"location"
]
}
}
}
}
]
}
29 changes: 29 additions & 0 deletions tests/appsec/rasp/test_api10.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,3 +375,32 @@ def test_api10_redirect(self):
assert self.r.status_code == 200
interfaces.library.validate_one_span(self.r, validator=self.validate)
interfaces.library.validate_one_span(self.r, validator=self.validate_metric)


@rfc("https://docs.google.com/document/d/1gCXU3LvTH9en3Bww0AC2coSJWz1m7HcavZjvMLuDCWg/edit#heading=h.giijrtyn1fdx")
@features.api10
@scenarios.appsec_rasp_non_blocking
class Test_API10_redirect_status(API10):
"""API 10 for multiple redirect responses. Check status code analysis."""

TAGS_EXPECTED = [
("_dd.appsec.trace.req_headers", "TAG_API10_REQ_HEADERS"),
]

TAGS_EXPECTED_METRIC = [
("_dd.appsec.downstream_request", "5"),
]

PARAMS = {"Witness": "pwq3ojtropiw3hjtowir", "totalRedirects": "3"}

def setup_api10_redirect(self):
self.r = weblog.get("/external_request/redirect", params=self.PARAMS)

def test_api10_redirect(self):
assert self.r.status_code == 200
# interfaces.library.validate_one_span(self.r, validator=self.validate)
interfaces.library.validate_one_span(self.r, validator=self.validate_metric)
for _, _trace, span in interfaces.library.get_spans(request=self.r):
meta = span.get("meta", {})
assert isinstance(meta.get("appsec.api.redirection.move_target", None), str), f"missing tag in {meta}"
assert "/redirect?totalRedirects=2" in meta["appsec.api.redirection.move_target"]
7 changes: 2 additions & 5 deletions utils/_context/_scenarios/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,18 +1030,15 @@ class _Scenarios:
},
)

appsec_rasp_non_blocking = EndToEndScenario(
appsec_rasp_non_blocking = AppsecRaspScenario(
"APPSEC_RASP_NON_BLOCKING",
weblog_env={"DD_APPSEC_RASP_ENABLED": "true", "DD_APPSEC_RULES": "/appsec_rasp_non_blocking_ruleset.json"},
weblog_env={"DD_APPSEC_RULES": "/appsec_rasp_non_blocking_ruleset.json"},
weblog_volumes={
"./tests/appsec/rasp/rasp_non_blocking_ruleset.json": {
"bind": "/appsec_rasp_non_blocking_ruleset.json",
"mode": "ro",
}
},
doc="Enable APPSEC RASP",
github_workflow="endtoend",
scenario_groups=[scenario_groups.appsec],
)

appsec_ato_sdk = EndToEndScenario(
Expand Down
12 changes: 10 additions & 2 deletions utils/_context/_scenarios/appsec_rasp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,16 @@


class AppsecRaspScenario(EndToEndScenario):
def __init__(self, name: str, weblog_env: dict[str, str | None] | None = None):
def __init__(
self,
name: str,
weblog_env: dict[str, str | None] | None = None,
weblog_volumes: dict[str, dict[str, str]] | None = None,
):
if weblog_env is None:
weblog_env = {}
if weblog_volumes is None:
weblog_volumes = {}

default_env: dict[str, str | None] = {
"DD_APPSEC_RASP_ENABLED": "true",
Expand All @@ -25,7 +32,8 @@ def __init__(self, name: str, weblog_env: dict[str, str | None] | None = None):
weblog_env=merged_env,
weblog_volumes={
"./tests/appsec/rasp/rasp_ruleset.json": {"bind": "/appsec_rasp_ruleset.json", "mode": "ro"}
},
}
| weblog_volumes,
doc="Enable APPSEC RASP",
github_workflow="endtoend",
scenario_groups=[scenario_groups.appsec, scenario_groups.appsec_rasp, scenario_groups.appsec_rasp_scenario],
Expand Down
Loading