Sign-In With Incomplete ORCID Profile Causes Account Creation to Fail

[artntek]

When creating an ORCID, the Last Name field is optional. However, for DataONE, familyName is a required field.

If an ORCID is created without a last name, and is used to log into a DataONE portal, the DataONE account creation fails silently.

Steps to reproduce

1. Create an ORCID that includes ONLY the required fields: first/given name, and primary email. Leave last name blank.
2. Log into https://search.dataone.org/signin using this new ORCID
3. Search for a new account containing your ORCID. For example, assuming your new ORCID is something like: https://orcid.org/0000-0002-1472-913X, use a search query like this:

   https://cn.dataone.org/cn/v2/accounts?query=0000-0002-1472-913X

Observed

No account is shown; the search returns:

<ns2:subjectInfo xmlns:ns2="http://ns.dataone.org/service/types/v1"/>

Expected

Your new account is shown; the search returns:

<ns2:subjectInfo xmlns:ns2="http://ns.dataone.org/service/types/v1">
  <person>
    <subject>http://orcid.org/0000-0002-1472-913X</subject>
    <givenName>Matthew</givenName>
    <familyName>Brooke</familyName>
    <verified>false</verified>
  </person>
</ns2:subjectInfo>