Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to know it's working #24

Open
atn38 opened this issue Apr 9, 2021 · 8 comments
Open

how to know it's working #24

atn38 opened this issue Apr 9, 2021 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@atn38
Copy link

atn38 commented Apr 9, 2021

Hello scythe team,

Kudos and thanks for developing this! I've gotten around to trying it out, and given my unfamiliarity with the databases and their APIs, am not sure if it's working right. I wasn't able to find any citations for our site's data holdings, despite knowing that there are >4 (and finding them on the Scopus). Relevant points imo:

  • I did use DOIs from all revisions of datasets, so I don't think it is a versioning issue
  • I was able to produce results from the example, so i think I set up scythe correctly
  • attached is a .txt of DOIs I used
    dois.txt

(Also I have access to the dataONE slack but can't find my login, happy to try and find it if that's a better place for these questions.)

@jeanetteclark
Copy link
Collaborator

Hi An! So happy to hear you are testing out the package. It is definitely in its infancy and we are looking forward to developing it more and making it more robust. I tested against your identifiers and also did not get any results. Can you send a list of known citation pairs (just a couple of examples, the dataset DOI and publication DOI) so that I can have a look to try and figure out why they aren't getting picked up?

Thanks!

@atn38
Copy link
Author

atn38 commented Apr 9, 2021

@jeanetteclark
Copy link
Collaborator

Hey @atn38 - I'm trying to have a look at this now but the Scopus website is giving me a hard time. If you can jump on the DataONE slack to chat about it, that would be helpful! Otherwise I can send you an invite to the NCEAS slack

@jeanetteclark
Copy link
Collaborator

After doing some digging, I realized that passing a list of identifiers wasn't working as expected - only the first identifier was searched. I fixed this in c295a3b, and also made sure to drop empty rows from result data frames so that you don't end up with a bunch of empty rows in the result set.

@atn38 if you install from develop and see the results you are expecting, let me know and I'll close this issue. I might make a minor release to incorporate these bug fixes into main

@jeanetteclark jeanetteclark added the bug Something isn't working label Apr 13, 2021
@jeanetteclark jeanetteclark self-assigned this Apr 13, 2021
@mbjones
Copy link
Member

mbjones commented Apr 13, 2021

Thanks for the report @atn38, and the fix @jeanetteclark. Does this bug affect our previous searches that @MayaSamet executed, such that it might be useful to repeat them now that it is fixed?

@jeanetteclark
Copy link
Collaborator

@mbjones no it does not - the bug was introduced in my last development push about a month ago, towards the end of it

@atn38
Copy link
Author

atn38 commented Apr 16, 2021

@jeanetteclark, I ran it again from the develop branch and was able to run citation_search and have it return results, so hooray!

with that said, the function didn't pick up these two articles that AFAIK are indexed in scopus and do cite our data DOIs:

https://doi.org/10.3389/feart.2020.598933
https://doi.org/10.1029/2020GB006552

@jeanetteclark
Copy link
Collaborator

Thanks @atn38! I'll have to look into these missed results later - I need to focus on other things at the moment, but I'll keep this issue open, and if you want to poke around, like Matt mentioned you are welcome to submit a PR for any improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants