You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Some meta-packages re-export from other packages, e.g. ember re-exports from @ember/*. For example, editing ember and @ember/template (as in this PR) triggers the merge bot's flag that there are multiple packages edited ("edits multiple packages, it can be merged once it's reviewed by a DT maintainer"). It'd be great if a set of packages on DT could be grouped so that mergebot understands that they're related changes and can safely land together if an owner approves.
The text was updated successfully, but these errors were encountered:
I think that this would work better once there's a way for your packages to declare a requirement for owner approval (re the other issue, which was not implemented yet). This would work nicely with the recent changes to show when owners of all packages approved a PR.
[
Detecting re-exports is unlikely to be practical. (The bot does not have a complete tree checked out ATM, and it would be a pretty big chunk of work to do that, not to mention the likelihood of not being able to store it in a small azure function.)
Adding some way to declare relationships might be more practical, but it'll complicate things.
Those constraints totally make sense! I definitely would assume that this kind of thing would require active management from owners, and explicit declarations of the relationships. Doing it by way of inspecting the AST or something like that would certainly seem to be prohibitively expensive.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Some meta-packages re-export from other packages, e.g.
ember
re-exports from@ember/*
. For example, editingember
and@ember/template
(as in this PR) triggers the merge bot's flag that there are multiple packages edited ("edits multiple packages, it can be merged once it's reviewed by a DT maintainer"). It'd be great if a set of packages on DT could be grouped so that mergebot understands that they're related changes and can safely land together if an owner approves.The text was updated successfully, but these errors were encountered: