-
Notifications
You must be signed in to change notification settings - Fork 28
Expand file tree
/
Copy pathpeople.py
More file actions
586 lines (496 loc) · 20.8 KB
/
Copy pathpeople.py
File metadata and controls
586 lines (496 loc) · 20.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
import re
from urllib.parse import quote
from auth_helpers.views import GroupRequiredMixin, user_in_group
from candidates.models.db import ActionType
from django.conf import settings
from django.contrib import messages
from django.contrib.auth.mixins import LoginRequiredMixin
from django.core.exceptions import PermissionDenied
from django.db import transaction
from django.http import (
Http404,
HttpResponsePermanentRedirect,
HttpResponseRedirect,
)
from django.shortcuts import get_object_or_404
from django.template.loader import render_to_string
from django.urls import reverse
from django.utils.decorators import method_decorator
from django.views.decorators.cache import cache_control
from django.views.generic import FormView, TemplateView, UpdateView, View
from django.views.generic.detail import DetailView
from duplicates.forms import DuplicateSuggestionForm
from elections.mixins import ElectionMixin
from elections.models import Election
from elections.uk.forms import SelectBallotForm
from people.forms.forms import NewPersonForm, UpdatePersonForm
from people.forms.formsets import (
PersonIdentifierFormsetFactory,
PersonMembershipFormsetFactory,
)
from people.models import Person
from popolo.models import NotStandingValidationError
from ynr.apps.people.merging import InvalidMergeError, PersonMerger
from ..diffs import get_version_diffs
from ..models import (
TRUSTED_TO_MERGE_GROUP_NAME,
Ballot,
LoggedAction,
PersonRedirect,
)
from ..models.versions import revert_person_from_version_data
from .helpers import ProcessInlineFormsMixin
from .version_data import get_change_metadata, get_client_ip
def get_call_to_action_flash_message(person, new_person=False):
"""Get HTML for a flash message after a person has been created or updated"""
return render_to_string(
"candidates/_person_update_call_to_action.html",
{
"new_person": new_person,
"person_url": reverse(
"person-view", kwargs={"person_id": person.id}
),
"person_edit_url": reverse(
"person-update", kwargs={"person_id": person.id}
),
"person_name": person.name,
"needing_attention_url": reverse("attention_needed"),
# We want to offer the option to add another candidate in
# any of the elections that this candidate is standing in,
# which means we'll need the "create person" URL and
# election name for each of those elections:
"create_for_election_options": [
(
reverse(
"person-create",
kwargs={"ballot_paper_id": ballot.ballot_paper_id},
),
ballot.post.label,
)
for ballot in Ballot.objects.filter(
membership__person=person, election__current=True
)
.select_related("post")
.distinct()
.order_by("ballot_paper_id")
],
},
)
SUGGESTION_FORM_ID = "suggestion"
MERGE_FORM_ID = "merge"
class PersonView(TemplateView):
template_name = "candidates/person-view.html"
@method_decorator(cache_control(max_age=(60 * 20)))
def dispatch(self, *args, **kwargs):
return super().dispatch(*args, **kwargs)
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
path = self.person.get_absolute_url()
context["redirect_after_login"] = quote(path)
context["canonical_url"] = self.person.wcivf_url()
context["person"] = self.person
context["other_names"] = self.person.other_names
if not self.request.user.is_authenticated:
context["other_names"] = context["other_names"].filter(
needs_review=False
)
context["elections_to_list"] = Election.objects.filter(
ballot__membership__person=self.person
).order_by("-election_date")
context["last_candidacy"] = self.person.last_candidacy
context["election_to_show"] = None
context["has_current_elections"] = (
context["elections_to_list"].current_or_future().exists()
)
context["person_edits_allowed"] = self.person.user_can_edit(
self.request.user
)
context["SUGGESTION_FORM_ID"] = SUGGESTION_FORM_ID
return context
def get(self, request, *args, **kwargs):
person_id = self.kwargs["person_id"]
try:
self.person = (
Person.objects.with_biography_last_updated()
.prefetch_related(
"memberships__ballot",
"memberships__ballot__post",
"memberships__ballot__election",
"tmp_person_identifiers",
)
.get(pk=person_id)
)
except Person.DoesNotExist:
try:
return self.get_person_redirect(person_id)
except PersonRedirect.DoesNotExist:
raise Http404(
"No person found with ID {person_id}".format(
person_id=person_id
)
)
return super().get(request, *args, **kwargs)
def get_person_redirect(self, person_id):
# If there's a PersonRedirect for this person ID, do the
# redirect, otherwise process the GET request as usual.
# try:
new_person_id = PersonRedirect.objects.get(
old_person_id=person_id
).new_person_id
return HttpResponsePermanentRedirect(
reverse("person-view", kwargs={"person_id": new_person_id})
)
class RevertPersonView(LoginRequiredMixin, View):
http_method_names = ["post"]
def post(self, request, *args, **kwargs):
version_id = self.request.POST["version_id"]
person_id = self.kwargs["person_id"]
source = self.request.POST["source"]
with transaction.atomic():
person = get_object_or_404(Person, id=person_id)
versions = person.versions
data_to_revert_to = None
for version in versions:
if version["version_id"] == version_id:
data_to_revert_to = version["data"]
break
if not data_to_revert_to:
message = "Couldn't find the version {0} of person {1}"
raise Exception(message.format(version_id, person_id))
change_metadata = get_change_metadata(self.request, source)
# Update the person here...
revert_person_from_version_data(person, data_to_revert_to)
person.record_version(change_metadata)
person.save()
# Log that that action has taken place, and will be shown in
# the recent changes, leaderboards, etc.
LoggedAction.objects.create(
user=self.request.user,
person=person,
action_type=ActionType.PERSON_REVERT,
ip_address=get_client_ip(self.request),
popit_person_new_version=change_metadata["version_id"],
source=change_metadata["information_source"],
)
return HttpResponseRedirect(
reverse("person-view", kwargs={"person_id": person_id})
)
class MergePeopleMixin:
def do_merge(self, primary_person, secondary_person):
merger = PersonMerger(
primary_person, secondary_person, request=self.request
)
return merger.merge(delete=True)
class DuplicatePersonView(LoginRequiredMixin, FormView, DetailView):
"""
A view that allows a user to suggest a duplicate person. Users with merge
permissions can merge directly rather than creating a DuplicateSuggestion
"""
http_method_names = ["get", "post"]
template_name = "duplicates/duplicate_suggestion.html"
model = Person
context_object_name = "person"
pk_url_kwarg = "person_id"
extra_context = {
"SUGGESTION_FORM_ID": SUGGESTION_FORM_ID,
"MERGE_FORM_ID": MERGE_FORM_ID,
}
form_class = DuplicateSuggestionForm
def get_form_kwargs(self):
kwargs = super().get_form_kwargs()
kwargs["person"] = self.object
kwargs["user"] = self.request.user
if self.request.method == "GET":
kwargs["data"] = self.request.GET
return kwargs
def get(self, request, *args, **kwargs):
self.object = self.get_object()
context = self.get_context_data()
form = context["form"]
if not form.is_valid():
context["errors"] = True
return self.render_to_response(context)
def post(self, request, *args, **kwargs):
self.object = self.get_object()
return super().post(request, *args, **kwargs)
def form_valid(self, form):
"""
Create the suggestestion, add a message, and redirect to
person profile they came from
"""
with transaction.atomic():
suggestion = form.save()
LoggedAction.objects.create(
user=self.request.user,
person=self.object,
action_type=ActionType.DUPLICATE_SUGGEST,
ip_address=get_client_ip(self.request),
source="duplicate person suggested",
)
msg = f"Thanks, your duplicate suggestion for ID:{suggestion.person.pk} and ID:{suggestion.other_person.pk} was created."
messages.add_message(
request=self.request,
level=messages.SUCCESS,
message=msg,
extra_tags="safe do-something-else",
)
return HttpResponseRedirect(self.object.get_absolute_url())
def get_context_data(self, **kwargs):
"""
Check whether user can merge directly, which is used in the
template to determine whether merge button is displayed
"""
context = super().get_context_data(**kwargs)
context["user_can_merge"] = user_in_group(
self.request.user, TRUSTED_TO_MERGE_GROUP_NAME
)
return context
class MergePeopleView(GroupRequiredMixin, TemplateView, MergePeopleMixin):
http_method_names = ["get", "post"]
required_group_name = TRUSTED_TO_MERGE_GROUP_NAME
template_name = "candidates/generic-merge-error.html"
def validate(self, context):
if not re.search(r"^\d+$", context["other_person_id"]):
message = "Malformed person ID '{0}'"
raise InvalidMergeError(message.format(context["other_person_id"]))
if context["person"].pk == int(context["other_person_id"]):
message = "You can't merge a person ({0}) with themself ({1})"
raise InvalidMergeError(
message.format(context["person"].pk, context["other_person_id"])
)
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
context["person"] = get_object_or_404(
Person, id=self.kwargs["person_id"]
)
context["other_person_id"] = self.request.POST.get("other_person", "")
return context
def post(self, request, *args, **kwargs):
context = self.get_context_data()
# Check that the person IDs are well-formed:
try:
self.validate(context)
except InvalidMergeError as e:
context["error_message"] = e
return self.render_to_response(context)
with transaction.atomic():
secondary_person = get_object_or_404(
Person, id=context["other_person_id"]
)
try:
merged_person = self.do_merge(
context["person"], secondary_person
)
except NotStandingValidationError:
return HttpResponseRedirect(
reverse(
"person-merge-correct-not-standing",
kwargs={
"person_id": context["person"].pk,
"other_person_id": context["other_person_id"],
},
)
)
# And redirect to the primary person with the merged data:
return HttpResponseRedirect(merged_person.get_absolute_url())
class CorrectNotStandingMergeView(
GroupRequiredMixin, TemplateView, MergePeopleMixin
):
template_name = "people/correct_not_standing_in_merge.html"
required_group_name = TRUSTED_TO_MERGE_GROUP_NAME
def extract_not_standing_edit(self, election, versions):
versions_json = versions
for version in versions_json:
try:
membership = version["data"]["standing_in"][election.slug]
if membership is None:
return version
except KeyError:
continue
return None
def populate_not_standing_list(self, person, person_not_standing):
for membership in person.memberships.all():
if (
membership.ballot.election
in person_not_standing.not_standing.all()
):
self.not_standing_elections.append(
{
"election": membership.ballot.election,
"person_standing": person,
"person_standing_ballot": membership.ballot,
"person_not_standing": person_not_standing,
"version": self.extract_not_standing_edit(
membership.ballot.election,
person_not_standing.versions,
),
}
)
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
context["person_a"] = get_object_or_404(
Person, id=self.kwargs["person_id"]
)
context["person_b"] = get_object_or_404(
Person, id=self.kwargs["other_person_id"]
)
self.not_standing_elections = []
self.populate_not_standing_list(
context["person_a"], context["person_b"]
)
self.populate_not_standing_list(
context["person_b"], context["person_a"]
)
context["not_standing_elections"] = self.not_standing_elections
return context
def post(self, request, *args, **kwargs):
context = self.get_context_data()
with transaction.atomic():
for pair in context["not_standing_elections"]:
pair["person_not_standing"].not_standing.remove(
pair["election"]
)
merged_person = self.do_merge(context["person_a"], context["person_b"])
# And redirect to the primary person with the merged data:
return HttpResponseRedirect(merged_person.get_absolute_url())
class UpdatePersonView(LoginRequiredMixin, ProcessInlineFormsMixin, UpdateView):
template_name = "candidates/person-edit.html"
queryset = Person.objects.all()
pk_url_kwarg = "person_id"
form_class = UpdatePersonForm
inline_formset_classes = {
"identifiers_formset": PersonIdentifierFormsetFactory,
"memberships_formset": PersonMembershipFormsetFactory,
}
def get_inline_formset_kwargs(self, formset_name):
kwargs = {}
if formset_name == "memberships_formset":
kwargs.update({"form_kwargs": {"user": self.request.user}})
if formset_name == "identifiers_formset":
model = self.inline_formset_classes["identifiers_formset"].model
kwargs.update({"queryset": model.objects.editable_value_types()})
return kwargs
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
person = self.object
context["person"] = person
context["person_edits_allowed"] = person.user_can_edit(
self.request.user
)
context["current_locked_ballots"] = person.memberships.filter(
ballot__election__current=True, ballot__candidates_locked=True
)
context["versions"] = get_version_diffs(person.versions)
return context
def form_valid(self, all_forms):
form = all_forms["form"]
if not (settings.EDITS_ALLOWED or self.request.user.is_staff):
return HttpResponseRedirect(reverse("all-edits-disallowed"))
context = self.get_context_data()
if not context["person_edits_allowed"]:
raise PermissionDenied
identifiers_formset = all_forms["identifiers_formset"]
membership_formset = all_forms["memberships_formset"]
with transaction.atomic():
# Lock the person record to prevent race conditions
person = Person.objects.select_for_update().get(
id=context["person"].id
)
identifiers_formset.instance = person
identifiers_formset.save()
membership_formset.save()
person = form.save(user=self.request.user)
change_metadata = get_change_metadata(
self.request, form.cleaned_data.pop("source")
)
person.record_version(change_metadata)
person.save()
LoggedAction.objects.create(
user=self.request.user,
person=person,
action_type=ActionType.PERSON_UPDATE,
ip_address=get_client_ip(self.request),
popit_person_new_version=change_metadata["version_id"],
source=change_metadata["information_source"],
)
# Add a message to be displayed after redirect:
messages.add_message(
self.request,
messages.SUCCESS,
get_call_to_action_flash_message(person, new_person=False),
extra_tags="safe do-something-else",
)
return HttpResponseRedirect(
reverse("person-view", kwargs={"person_id": person.id})
)
class NewPersonSelectElectionView(LoginRequiredMixin, FormView):
"""
For when we know new person's name, but not the election they are standing
in. This is normally because we've not come via a post page to add a new
person (e.g., we've come from the search results page).
"""
template_name = "candidates/person-create-select-election.html"
form_class = SelectBallotForm
def get_context_data(self, **kwargs):
context = super(NewPersonSelectElectionView, self).get_context_data(
**kwargs
)
context["name"] = self.request.GET.get("name")[:150]
return context
def form_valid(self, form):
context = self.get_context_data()
name = context["name"]
ballot_paper_id = form.cleaned_data["ballot"].ballot_paper_id
return HttpResponseRedirect(
reverse(
"person-create", kwargs={"ballot_paper_id": ballot_paper_id}
)
+ f"?name={name}"
)
class NewPersonView(
ProcessInlineFormsMixin, ElectionMixin, LoginRequiredMixin, FormView
):
template_name = "candidates/person-create.html"
form_class = NewPersonForm
inline_formset_classes = {
"identifiers_formset": PersonIdentifierFormsetFactory
}
def get_initial(self):
result = super().get_initial()
result["ballot_paper_id"] = self.get_ballot()
result["name"] = self.request.GET.get("name")
return result
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
context["add_candidate_form"] = context["form"]
return context
def form_valid(self, all_forms):
form = all_forms["form"]
identifiers_formset = all_forms["identifiers_formset"]
with transaction.atomic():
person = form.save()
identifiers_formset.instance = person
identifiers_formset.save()
change_metadata = get_change_metadata(
self.request, form.cleaned_data["source"]
)
person.record_version(change_metadata)
person.save()
LoggedAction.objects.create(
user=self.request.user,
person=person,
action_type=ActionType.PERSON_CREATE,
ip_address=get_client_ip(self.request),
popit_person_new_version=change_metadata["version_id"],
source=change_metadata["information_source"],
)
# Add a message to be displayed after redirect:
messages.add_message(
self.request,
messages.SUCCESS,
get_call_to_action_flash_message(person, new_person=True),
extra_tags="safe do-something-else",
)
return HttpResponseRedirect(
reverse("person-view", kwargs={"person_id": person.id})
)