New CSS overwriting for both Safari and Firefox extension

[DennisSnijder]

As Github changed the "dark-header" class.
The Firefox and Safari extensions are broken.

This needs to be fixed.

[xeno-by]

Doesn't work for me on Chrome either.

[DennisSnijder]

@xeno-by Try the new version on the master branch.
Update will be published ASAP to the chrome extension store.

[xeno-by]

@DennisSnijder I can confirm this working for me. Thank you!

[DennisSnijder]

@xeno-by Thanks for testing 👍
Updated it couple of minutes ago.

[delneg]

Confirmed, updated from master and it's working now.
That black glow of death freaked me out for several minutes though.

[fabricionaweb]

@DennisSnijder, I was preparing a PR when you updated hehe
That would be my CSS, take some improvements.

/* A higher specification avoids `!important` */
.header.great-header {
    border-bottom: 1px solid #E5E5E5;
    background-color: #F5F5F5;
    height: 54px; /* prevents reflow */
}

.header.great-header .header-logo-invertocat,
.header.great-header .header-logo-wordmark {
    color: #555;
}

.header.great-header .header-logo-invertocat:hover,
.header.great-header .header-logo-wordmark:hover {
    color: #4078C0;
}

.header.great-header .header-nav-link {
    color: #555;
}

.header.great-header .header-nav-link:hover,
.header.great-header .header-nav-link:focus {
    color: #4078c0;
}

.header.great-header .header-nav-link:hover .dropdown-caret,
.header.great-header .header-nav-link:focus .dropdown-caret {
    border-top-color: #4078c0;
}

.header.great-header .notification-indicator .mail-status {
    border-color: #f3f3f3;
}

.header.great-header .header-search-scope {
    color: #767676;
    border-right-color: #EEE;
}

.header.great-header .header-search-wrapper {
    color: #333;
    background-color: #FFF;
    border: 1px solid #DDD;
    box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.075);
}

.header.great-header .header-search-wrapper.focus {
    background-color: #FFF;
    border-color: #51A7E8;
    box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.075), 
                0 0 5px rgba(81, 167, 232, 0.5);
}

.header.great-header .header-search-wrapper.focus .header-search-scope {
    color: #4078C0;
    background-color: #EDF2F9;
    border-right-color: #C6D7EC;
}

.header.great-header .header-search-input {
    color: #333;
}

.header.great-header .header-search-input::-webkit-input-placeholder {
    color: #999;
}
.header.great-header .header-search-input:placeholder {
    color: #999;
}

.header.great-header .header-search-input::-moz-placeholder {
    color: #999;
}
.header.great-header .header-search-input:-moz-placeholder {
    color: #999;
}

[DennisSnijder]

@fabricionaweb Looks good! Feel free to create a Pull Request for that as there are some improvements indeed!

[ajayyy]

Is the chrome webstore version gonna be updated?

[kinncj]

Someone mentioned chrome?

Your item is in the process of being published and may take up to 60 minutes to appear in the Chrome Web Store.

:-)

[oe]

Why not concat github via Get Help with GitHub and complain about it? Let those guys know about it.

[oe]

They just replied. It's "official".

Hey Saiya,

Thanks for reaching out and sharing your feedback with us. I'll pass your feedback on to our team to consider.

I believe that the header CSS classes were changed as part of a cleanup from when the header was being tested. You're more than welcome to change the color with a user script, we definitely don't try to prevent you from doing that! And as I mentioned, I'll be sure to let the team know that you'd like to see the old header again. :)

Let me know if you have any other feedback, or any questions!

Cheers,
Antonio
GitHub Support

I just wrote a user script to remove the dark topbar yesterday, but now you just changed your way to approach that. That's funny. We(users) tell you what's a good design, but you are just deaf. Please be aware of you have several competitors in the source code hosting market.

[adriaandotcom]

Saiya wrote:

I just wrote a user script to remove the dark topbar yesterday, but now you just changed your way to approach that. That's funny. We(users) tell you what's a good design, but you are just deaf. Please be aware of you have several competitors in the source code hosting market.

I would love to go on a vacation with you! 🏖