Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primer results for sympy and spack are flaky #563

Open
DetachHead opened this issue Aug 11, 2024 · 2 comments
Open

primer results for sympy and spack are flaky #563

DetachHead opened this issue Aug 11, 2024 · 2 comments
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream

Comments

@DetachHead
Copy link
Owner

DetachHead commented Aug 11, 2024

there are differences on changes that don't touch type checking code at all. as far as i can tell some upstream change has caused some sort of flake that causes it to have different results on each run. some examples:

worth noting that i think the reason these don't show up on upstream primer comments is because most rules arent enabled on the upstream repo (which seems to cause a lot of bugs that go undetected)

@DetachHead DetachHead added the type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules label Aug 11, 2024
@DetachHead DetachHead added the upstream bug a bug that also exists in pyright but has not been raised upstream label Aug 21, 2024
@DetachHead
Copy link
Owner Author

same with spack, but those are more rare: #608 (comment)

@DetachHead DetachHead changed the title primer results for sympy are flaky primer results for sympy and spack are flaky Sep 22, 2024
@DetachHead
Copy link
Owner Author

upstream issue: microsoft/pyright#10039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream
Projects
None yet
Development

No branches or pull requests

1 participant