Do not directly reference packagelist methods from xaml, use x:bind instead

Author: marticliment

src/UniGetUI/Controls/PackageWrapper.cs

@@ -1,6 +1,7 @@
 using System.Collections.Concurrent;
 using System.ComponentModel;
 using System.Runtime.InteropServices;
+using Microsoft.UI.Xaml.Input;
 using Microsoft.UI.Xaml.Media;
 using Microsoft.UI.Xaml.Media.Imaging;
 using UniGetUI.Core.Classes;
@@ -78,7 +79,17 @@ public PackageWrapper(IPackage package, AbstractPackagesPage page)
                 ExtendedTooltip = $"{package.Name} (from {package.Source.AsString_DisplayName})";
         }
 
-        public async void RightClick()
+        public void PackageItemContainer_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
+            => _page.PackageItemContainer_DoubleTapped(sender, e);
+
+        public void PackageItemContainer_PreviewKeyDown(object sender, KeyRoutedEventArgs e)
+            => _page.PackageItemContainer_PreviewKeyDown(sender, e);
+
+        public void PackageItemContainer_RightTapped(object sender, RightTappedRoutedEventArgs e)
+            => _page.PackageItemContainer_RightTapped(sender, e);
+
+
+        public async Task RightClick()
         {
             await _page.ShowContextMenu(this);
         }

src/UniGetUI/Pages/SoftwarePages/AbstractPackagesPage.xaml

@@ -35,11 +35,12 @@
             <widgets:PackageItemContainer
                 AutomationProperties.Name="{x:Bind Package.AutomationName}"
                 CornerRadius="4"
-                DoubleTapped="PackageItemContainer_DoubleTapped"
-                Package="{x:Bind Package}"
-                PreviewKeyDown="PackageItemContainer_PreviewKeyDown"
-                RightTapped="PackageItemContainer_RightTapped"
-                Wrapper="{x:Bind Self}">
+                DoubleTapped="{x:Bind PackageItemContainer_DoubleTapped}"
+                PreviewKeyDown="{x:Bind PackageItemContainer_PreviewKeyDown}"
+                RightTapped="{x:Bind PackageItemContainer_RightTapped}"
+
+                Wrapper="{x:Bind Self}"
+                Package="{x:Bind Package}">
 
                 <Grid
                     Padding="12,3,8,3"
@@ -210,10 +211,11 @@
                 AutomationProperties.Name="{x:Bind Package.AutomationName}"
                 Background="{ThemeResource ControlFillColorDefaultBrush}"
                 CornerRadius="4"
-                DoubleTapped="PackageItemContainer_DoubleTapped"
+                DoubleTapped="{x:Bind PackageItemContainer_DoubleTapped}"
+                PreviewKeyDown="{x:Bind PackageItemContainer_PreviewKeyDown}"
+                RightTapped="{x:Bind PackageItemContainer_RightTapped}"
+
                 Package="{x:Bind Package}"
-                PreviewKeyDown="PackageItemContainer_PreviewKeyDown"
-                RightTapped="PackageItemContainer_RightTapped"
                 Wrapper="{x:Bind Self}">
 
                 <Grid
@@ -328,10 +330,11 @@
                 AutomationProperties.Name="{x:Bind Package.AutomationName}"
                 Background="{ThemeResource ControlFillColorDefaultBrush}"
                 CornerRadius="4"
-                DoubleTapped="PackageItemContainer_DoubleTapped"
+                DoubleTapped="{x:Bind PackageItemContainer_DoubleTapped}"
+                PreviewKeyDown="{x:Bind PackageItemContainer_PreviewKeyDown}"
+                RightTapped="{x:Bind PackageItemContainer_RightTapped}"
+
                 Package="{x:Bind Package}"
-                PreviewKeyDown="PackageItemContainer_PreviewKeyDown"
-                RightTapped="PackageItemContainer_RightTapped"
                 Wrapper="{x:Bind Self}">
 
                 <Grid

src/UniGetUI/Pages/SoftwarePages/AbstractPackagesPage.xaml.cs

@@ -978,7 +978,7 @@ protected void PerformMainPackageAction(IPackage? package)
         }
 
         public void FocusPackageList()
-        { CurrentPackageList.Focus(FocusState.Programmatic); }
+            => CurrentPackageList.Focus(FocusState.Programmatic);
 
 
         public async Task ShowContextMenu(PackageWrapper wrapper)
@@ -990,7 +990,7 @@ public async Task ShowContextMenu(PackageWrapper wrapper)
             WhenShowingContextMenu(wrapper.Package);
         }
 
-        private void PackageItemContainer_RightTapped(object sender, RightTappedRoutedEventArgs e)
+        public void PackageItemContainer_RightTapped(object sender, RightTappedRoutedEventArgs e)
         {
             if (sender is PackageItemContainer container && container.Package is not null)
             {
@@ -1000,7 +1000,7 @@ private void PackageItemContainer_RightTapped(object sender, RightTappedRoutedEv
             }
         }
 
-        private void PackageItemContainer_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
+        public void PackageItemContainer_DoubleTapped(object sender, DoubleTappedRoutedEventArgs e)
         {
             if (sender is PackageItemContainer container && container.Package is not null)
             {
@@ -1138,7 +1138,7 @@ public void OnLeave()
             IsEnabled = false;
         }
 
-        private void PackageItemContainer_PreviewKeyDown(object sender, KeyRoutedEventArgs e)
+        public void PackageItemContainer_PreviewKeyDown(object sender, KeyRoutedEventArgs e)
         {
             if (e.Key is not (VirtualKey.Up or VirtualKey.Down or VirtualKey.Home or VirtualKey.End or VirtualKey.Enter or VirtualKey.Space) ||
                 sender is not PackageItemContainer packageItemContainer)