Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Infra code for contributing #4

Open
GwonsooLee opened this issue Jul 12, 2020 · 2 comments
Open

Test Infra code for contributing #4

GwonsooLee opened this issue Jul 12, 2020 · 2 comments
Assignees
@GwonsooLee
Labels
help wanted Extra attention is needed

Comments

@GwonsooLee
Copy link
Member

GwonsooLee commented Jul 12, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
There is no test code before checking goployer works in local system. Also if someone ones to deploy with goployer in the AWS environment, ALB, TGs are needed before testing.

Describe the solution you'd like
Terraform code is needed

Additional context
Before considering local test, we should have pre-test environment for contributing.
@jupitersong
@GwonsooLee GwonsooLee added the help wanted Extra attention is needed label Jul 12, 2020
@GwonsooLee
Copy link
Member Author

@jupitersong, @asbubam
How about adopting CDK for test infra code?
https://docs.aws.amazon.com/cdk/latest/guide/getting_started.html

With AWS CDK, we can initiate installation of infrastructure for test in user's account. Of course we could provide terraform. Any opinion is welcome.

@GwonsooLee
Copy link
Member Author

Decide to go with Terraform

@GwonsooLee GwonsooLee assigned GwonsooLee and unassigned asbubam Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GwonsooLee GwonsooLee

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asbubam @GwonsooLee