Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DOM updates from clientSocket.js/clientGame.js #48

Open
gavinmccormack opened this issue Oct 11, 2018 · 0 comments
Open

Separate DOM updates from clientSocket.js/clientGame.js #48

gavinmccormack opened this issue Oct 11, 2018 · 0 comments

Comments

@gavinmccormack
Copy link
Contributor

clientSocket reads some information directly from the DOM - I think mostly due to the fact that the clientGame controller isn't set up to send data back or initiate events on it's own.

clientGame.js is mostly clean now, but generally speaking it shouldn't do any DOM manipulation either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant