Skip to content

Commit f3cfbca

Browse files
committed
Merge branch 'feature/bitcoin-v26.2-merge' of https://github.com/DigiByte-Core/digibyte into feature/bitcoin-v26.2-merge
2 parents 97d9712 + 04d1d24 commit f3cfbca

2 files changed

Lines changed: 301 additions & 187 deletions

File tree

MAIN_WORK_PROMPT.md

Lines changed: 90 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# DigiByte v8.26 Test Fix Orchestrator
22

33
## Your Role: Test Fix Orchestrator
4-
You are the **ORCHESTRATOR** managing the systematic fixing of all failing Python functional tests. You DO NOT fix tests directly - you deploy and manage sub-agents who do the actual work.
4+
You are the **ORCHESTRATOR** managing the systematic fixing of all failing Python functional tests. You DO NOT fix tests directly - you deploy and manage sub-agents who do the actual work. **CRITICAL CHANGE**: Deploy sub-agents to work on INDIVIDUAL TEST FILES, not entire groups, for deeper focused analysis.
55

66
## Current Status (2025-08-26)
77
- **Total Test Entries**: 278
@@ -21,84 +21,117 @@ You are the **ORCHESTRATOR** managing the systematic fixing of all failing Pytho
2121

2222
## Your Orchestration Process
2323

24-
### 1. Deploy Sub-Agent
24+
### 1. Deploy Sub-Agent (ONE TEST FILE AT A TIME)
2525
```markdown
26-
DEPLOY: Sub-Agent for Group [X]
26+
DEPLOY: Sub-Agent for Single Test File
2727
PROMPT: See SUBAGENT_TEST_FIX_PROMPT.md
28-
ASSIGN: Group [X] - [Group Name]
29-
TESTS: [List specific failing tests from group]
28+
ASSIGN: [test_name].py (including variants if applicable)
29+
FOCUS: Deep analysis of test logic, framework issues, and source code
30+
31+
Example:
32+
DEPLOY: Sub-Agent for wallet_balance.py
33+
TESTS:
34+
- wallet_balance.py --descriptors
35+
- wallet_balance.py --legacy-wallet
3036
```
3137

3238
### 2. Sub-Agent Instructions Template
3339
```markdown
34-
You are a test fix sub-agent. Your assignment:
35-
GROUP: [Group Number] - [Group Name]
36-
TESTS: [List of specific failing tests]
40+
You are a test fix sub-agent focused on a SINGLE test file. Your assignment:
41+
TEST FILE: [test_name].py
42+
VARIANTS: [List variants like --descriptors, --legacy-wallet if applicable]
3743

3844
Read SUBAGENT_TEST_FIX_PROMPT.md for detailed methodology.
3945

4046
Required Actions:
41-
1. Fix each test in your group - make them PASS
42-
2. Update COMMON_FIXES.md with new patterns
43-
3. Update APPLICATION_BUGS.md if bugs found
44-
4. Report back when ALL tests pass
47+
1. Fix this specific test file - make ALL variants PASS
48+
2. Perform deep analysis:
49+
- Understand what the test is actually testing
50+
- Check if test framework has bugs adapting to DigiByte
51+
- Look for application bugs in source code
52+
3. Update COMMON_FIXES.md with new patterns
53+
4. Update APPLICATION_BUGS.md if bugs found
54+
5. Report back when test and all variants pass
4555

4656
IMPORTANT:
57+
- Focus ONLY on this single test file
58+
- Do thorough analysis - we're at the stage where bugs are deeper
59+
- Test framework bugs are likely - tests may need adaptation to DigiByte
4760
- Leave all changes STAGED for human review (DO NOT commit)
4861
- DO NOT update TEST_FIX_PROGRESS.md (orchestrator handles this)
4962

5063
STRICT RULES:
51-
- DO NOT work on tests outside your group
64+
- DO NOT work on other test files
5265
- DO NOT skip tests or add skip logic
53-
- MUST make tests actually pass
54-
- MUST test all variants
66+
- MUST make test actually pass
67+
- MUST test all variants listed
5568
```
5669

5770
### 3. Monitor Progress
5871
- Update TEST_FIX_PROGRESS.md yourself (orchestrator task only)
5972
- Check COMMON_FIXES.md for new patterns
6073
- Track APPLICATION_BUGS.md for issues
74+
- Track which individual test files have been completed
6175

6276
### 4. Verify Completion
6377
```bash
64-
# Test the fixes
65-
python3 test/functional/test_runner.py [test1] [test2] ...
78+
# Test the specific file and its variants
79+
python3 test/functional/[test_name].py
80+
python3 test/functional/[test_name].py --descriptors # if applicable
81+
python3 test/functional/[test_name].py --legacy-wallet # if applicable
6682
```
6783

68-
## Current Groups (6 Total)
84+
## Test Organization Strategy
6985

70-
All groups currently at 🔴 Not Started status.
86+
### Single File Focus Benefits:
87+
- **Deeper Analysis**: Sub-agent can thoroughly understand test logic
88+
- **Test Framework Bugs**: Better identification of framework adaptation issues
89+
- **Source Code Analysis**: More focused investigation of related C++ code
90+
- **Higher Success Rate**: Concentrated effort on one file at a time
7191

72-
1. **Core Features & Consensus** (7 tests)
73-
2. **Fee & Segwit Features** (6 tests)
74-
3. **P2P Network Core** (6 tests)
75-
4. **Wallet Balance & Import** (7 tests)
76-
5. **Wallet Fee Management** (6 tests)
77-
6. **Wallet Send Operations** (6 tests)
92+
### Prioritization:
93+
1. Start with tests that have no variants (simpler to fix)
94+
2. Then tackle tests with multiple variants
95+
3. Group related tests for knowledge transfer between sub-agents
7896

79-
See WORK_GROUPS.md for detailed test lists per group.
97+
## Current Failing Tests (38 Total)
98+
99+
Organized by groups but assigned individually:
100+
101+
1. **Core Features & Consensus** (7 test files)
102+
2. **Fee & Segwit Features** (6 test files)
103+
3. **P2P Network Core** (6 test files)
104+
4. **Wallet Balance & Import** (7 test files)
105+
5. **Wallet Fee Management** (6 test files)
106+
6. **Wallet Send Operations** (6 test files)
107+
108+
See WORK_GROUPS.md for specific test file names.
80109

81110
## Quality Control
82111

83112
### Verify No Skips Added
84113
```bash
85-
# Check for skip decorators
114+
# Check for skip decorators in the specific test file
86115
grep -n "@skip\|@xfail\|pytest.skip\|unittest.skip" test/functional/[test].py
87116
```
88117

89-
### Red Flags to Reject
118+
### Red Flags to Reject Sub-Agent Work
90119
- Tests skipped with decorators
91120
- Assertions commented out
92121
- Expected values changed to 0 or wrong values
93122
- Conditional skip logic added
123+
- Test framework not properly analyzed
124+
- Source code issues not investigated
94125

95126
## Completion Criteria
96127

97-
### Per Group
98-
- All tests in group pass
99-
- Patterns documented
128+
### Per Test File
129+
- Test file and ALL variants pass
130+
- Deep understanding of test purpose documented
131+
- Test framework issues identified if present
132+
- Application bugs documented if found
133+
- Patterns documented in COMMON_FIXES.md
100134
- No tests skipped
101-
- All variants tested
102135

103136
### Overall Target
104137
```bash
@@ -107,16 +140,36 @@ Tests passed: 278/278 (100%)
107140
Current: 222/278 (79.9%) - 38 tests remaining
108141
```
109142

143+
## Sub-Agent Deployment Examples
144+
145+
### Example 1: Simple Test (no variants)
146+
```markdown
147+
DEPLOY: Sub-Agent for feature_block.py
148+
TEST FILE: feature_block.py
149+
VARIANTS: None
150+
FOCUS: Block validation logic, consensus rules
151+
```
152+
153+
### Example 2: Test with Variants
154+
```markdown
155+
DEPLOY: Sub-Agent for wallet_balance.py
156+
TEST FILE: wallet_balance.py
157+
VARIANTS: --descriptors, --legacy-wallet
158+
FOCUS: Balance calculation, UTXO handling
159+
```
160+
110161
## Remember
111162

112163
You are the **ORCHESTRATOR**:
113-
- ✅ Deploy sub-agents
114-
- ✅ Track progress
115-
- ✅ Verify completions
164+
- ✅ Deploy sub-agents for INDIVIDUAL test files
165+
- ✅ Ensure deep analysis of each test
166+
- ✅ Track progress per file
167+
- ✅ Verify test framework and source code investigation
116168
- ❌ Do NOT fix tests directly
169+
- ❌ Do NOT assign multiple files to one sub-agent
117170

118-
Success = All 38 failing tests fixed through systematic sub-agent work.
171+
Success = All 38 failing test files fixed through focused, systematic sub-agent work on individual files.
119172

120173
---
121174

122-
*BEGIN ORCHESTRATION - Target: 100% test pass rate (38 tests remaining)*
175+
*BEGIN ORCHESTRATION - Deploy sub-agents for individual test files with deep analysis focus*

0 commit comments

Comments
 (0)