Make jshint warn on unused variables.

Also remove a whole ton of them.

Author: kring

.jshintrc

@@ -15,7 +15,7 @@
   "quotmark": false,
   "regexp": false,
   "undef": true,
-  "unused": false,
+  "unused": "vars",
   "strict": true,
   "trailing": true,
   "asi": false,

spec/Map/unionRectanglesSpec.js

@@ -1,6 +1,6 @@
 'use strict';
 
-/*global require,describe,it,expect,beforeEach*/
+/*global require,describe,it,expect*/
 
 var Rectangle = require('../../third_party/cesium/Source/Core/Rectangle');
 

spec/ViewModels/CsvItemViewModelSpec.js

@@ -3,7 +3,6 @@
 /*global require,describe,it,expect,beforeEach*/
 
 var ApplicationViewModel = require('../../src/ViewModels/ApplicationViewModel');
-var ImageryLayerItemViewModel = require('../../src/ViewModels/ImageryLayerItemViewModel');
 var CatalogItemViewModel = require('../../src/ViewModels/CatalogItemViewModel');
 var CsvItemViewModel = require('../../src/ViewModels/CsvItemViewModel');
 
@@ -25,7 +24,7 @@ describe('CsvDataItemViewModel', function() {
 
     it('throws if constructed without an application', function() {
         expect(function() {
-            var viewModel = new CsvItemViewModel();
+            var viewModel = new CsvItemViewModel(); // jshint ignore:line
         }).toThrow();
     });
 

spec/ViewModels/WebMapServiceDataItemViewModelSpec.js

@@ -25,7 +25,7 @@ describe('WebMapServiceDataItemViewModel', function() {
 
     it('throws if constructed without an application', function() {
         expect(function() {
-            var viewModel = new WebMapServiceItemViewModel();
+            var viewModel = new WebMapServiceItemViewModel(); // jshint ignore:line
         }).toThrow();
     });
 

src/Core/inherit.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/*global require*/
-
 var inherit = function(base, derived) {
     function F() {}
     F.prototype = base.prototype;

src/Map/Dataset.js

@@ -182,7 +182,6 @@ Dataset.prototype._processVariables = function () {
 */
 Dataset.prototype.loadJson = function (jsonTable) {
 
-    var dataObject = { positions: [], dataValues: [] };
     this.dataShape = undefined;
 
     //create the variable set

src/Map/LeafletVisualizer.js

@@ -1,18 +1,16 @@
 
 "use strict";
 
-/*global require,L,URI,$,Document,alert,console*/
+/*global require,L*/
 var AssociativeArray = require('../../third_party/cesium/Source/Core/AssociativeArray');
 var Cartesian2 = require('../../third_party/cesium/Source/Core/Cartesian2');
-var Cartesian3 = require('../../third_party/cesium/Source/Core/Cartesian3');
 var Color = require('../../third_party/cesium/Source/Core/Color');
 var defined = require('../../third_party/cesium/Source/Core/defined');
 var destroyObject = require('../../third_party/cesium/Source/Core/destroyObject');
 var DeveloperError = require('../../third_party/cesium/Source/Core/DeveloperError');
 var Property = require('../../third_party/cesium/Source/DataSources/Property');
 var Ellipsoid = require('../../third_party/cesium/Source/Core/Ellipsoid');
 var CesiumMath = require('../../third_party/cesium/Source/Core/Math');
-var loadImage = require('../../third_party/cesium/Source/Core/loadImage');
 var writeTextToCanvas = require('../../third_party/cesium/Source/Core/writeTextToCanvas');
 
 

src/Map/TableDataSource.js

@@ -1,4 +1,4 @@
-/*global require,$*/
+/*global require*/
 "use strict";
 
 var Dataset = require('./Dataset');
@@ -11,7 +11,6 @@ And writes a czml file for it to display
 
 //TODO: DOCUMENT using model in GeoJsonDataSource
 
-var defaultValue = require('../../third_party/cesium/Source/Core/defaultValue');
 var defined = require('../../third_party/cesium/Source/Core/defined');
 var CzmlDataSource = require('../../third_party/cesium/Source/DataSources/CzmlDataSource');
 var Color = require('../../third_party/cesium/Source/Core/Color');

src/Map/VarType.js

@@ -1,14 +1,5 @@
-/*global require*/
-"use strict";
-
-/*!
- * Copyright(c) 2012-2013 National ICT Australia Limited (NICTA).  All rights reserved.
- */
+'use strict';
 
 var VarType = {LON: 0, LAT: 1, ALT: 2, TIME: 3, SCALAR: 4, ENUM: 5 };
 
-
 module.exports = VarType;
-
-
-

src/Map/gmlToGeoJson.js

@@ -1,6 +1,6 @@
 'use strict';
 
-/*global require,$*/
+/*global $*/
 
 function gmlToGeoJson(xml) {
     var json = $.xml2json(xml);