Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command delays #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix command delays #8

wants to merge 2 commits into from

Conversation

DocRevive
Copy link

As used in https://github.com/Dragory/modmailbot, each command prefilter may check a channel ID against an entire database of threads. As a standalone operation, this has an unnoticeable effect, but when there are over forty commands and nearly one hundred thousand threads, a consistent delay is present on every Modmail command run in the inbox server.

Recently, we pinpointed the source of the delay to this module. Several months ago, the support server advised us to contact Discord for selectively limiting the bot's requests to one particular server.

This change drastically improves the performance (1300ms to <1ms) of findMatchingCommand in large-scale workloads by putting the cheaper and more specific tryMatchingCommand check before the prefilters.

split tryMatchingCommand into prefix & name check and signature validation
@DocRevive
Copy link
Author

I realized that by switching the order this way, the error-handling block for tryMatchingCommand in findMatchingCommand would cause a response to incorrect command uses regardless of the prefilters. Now, tryMatchingCommand has been split into two parts. The first is used to check the name and prefix before the prefilters, and the second is used to validate the signature and prepare relevant error messages after the prefilters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant