UID returns client access_token instead of user id?

[ryenski]

Currently the uid attribute returns the access_token for the client request:

uid { access_token.client.id }

It seems like the uid attribute should return the Drip user's ID instead:

uid { raw_info["accounts"][0]['id'] }

[ryenski]

This was causing a problem in my app because the client.id corresponds to the authorized application, not the user who is authorizing. My understanding of the OmniAuth hash schema is that the uid should be the user's unique ID in the authorizing application (e.g. Drip's user id). Is this also your understanding?

I made this change in my local gem, and it works as expected. I'd like to submit a PR, however I'm not sure how to write a test for this. Do you have any thoughts on that?

[derrickreimer]

A PR would be welcome! This gem was originally authored by an external party, which is probably how this slipped through. You could look to the way the GitHub omniauth gem stubs out raw_info for guidance on how to test this: https://github.com/intridea/omniauth-github/blob/master/spec/omniauth/strategies/github_spec.rb. (Admittedly, test coverage as it stands right now is very limited).

[ryenski]

Good deal... I've got that PR ready for you