Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlFieldWithConverter does not select correct element #55

Open
cr3ativ3 opened this issue Mar 22, 2018 · 0 comments
Open

HtmlFieldWithConverter does not select correct element #55

cr3ativ3 opened this issue Mar 22, 2018 · 0 comments

Comments

@cr3ativ3
Copy link
Contributor

cr3ativ3 commented Mar 22, 2018

ElementConverter.class's javadoc states that @param node The matched {@code element} but it is not true. HtmlFieldWithConverter does not perform css selection before passing element to convert() method so the node element is actually the whole HTML document.

And even the custom convert test is faulty, you can change

"<p id=\"today-weather\">Today is Saturday. Weather is sunny</p>"

to:
"<p id=\"kdjkfajjdfhb-it-doesnt-matter\">Today is Saturday. Weather is sunny</p>" and the test will still pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant