From a69c7723b5b459711a5cfb854dcbdd1a3f4fef51 Mon Sep 17 00:00:00 2001 From: Roman Melnyk Date: Fri, 4 Nov 2022 08:48:21 +0200 Subject: [PATCH 1/2] #200 Add detailed error message for iOS onError function. --- ios/FastImage/FFFastImageView.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ios/FastImage/FFFastImageView.m b/ios/FastImage/FFFastImageView.m index f7100815e..f5d3afcd6 100644 --- a/ios/FastImage/FFFastImageView.m +++ b/ios/FastImage/FFFastImageView.m @@ -222,7 +222,9 @@ - (void) downloadImage: (FFFastImageSource*)source options: (SDWebImageOptions)o if (error) { weakSelf.hasErrored = YES; if (weakSelf.onFastImageError) { - weakSelf.onFastImageError(@{}); + weakSelf.onFastImageError(@{ + @"error": [NSString stringWithFormat: @"%@", error] + }); } if (weakSelf.onFastImageLoadEnd) { weakSelf.onFastImageLoadEnd(@{}); From a4e47554e1096b892762ff5a39ede0f85f9c4ee1 Mon Sep 17 00:00:00 2001 From: Roman Melnyk Date: Mon, 14 Nov 2022 16:03:05 +0200 Subject: [PATCH 2/2] #200 Add detailed error message for Android onError function. --- .../com/dylanvann/fastimage/FastImageRequestListener.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/dylanvann/fastimage/FastImageRequestListener.java b/android/src/main/java/com/dylanvann/fastimage/FastImageRequestListener.java index dbeb81313..28485b982 100644 --- a/android/src/main/java/com/dylanvann/fastimage/FastImageRequestListener.java +++ b/android/src/main/java/com/dylanvann/fastimage/FastImageRequestListener.java @@ -39,7 +39,9 @@ public boolean onLoadFailed(@androidx.annotation.Nullable GlideException e, Obje ThemedReactContext context = (ThemedReactContext) view.getContext(); RCTEventEmitter eventEmitter = context.getJSModule(RCTEventEmitter.class); int viewId = view.getId(); - eventEmitter.receiveEvent(viewId, REACT_ON_ERROR_EVENT, new WritableNativeMap()); + WritableMap errorEvent = new WritableNativeMap(); + errorEvent.putString("error", e != null ? e.getMessage() : "Load Failed"); + eventEmitter.receiveEvent(viewId, REACT_ON_ERROR_EVENT, errorEvent); eventEmitter.receiveEvent(viewId, REACT_ON_LOAD_END_EVENT, new WritableNativeMap()); return false; }