Skip to content

Commit 9dabe2c

Browse files
committed
Add a comment for strange looking dict comparison
1 parent ef56029 commit 9dabe2c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

eb_hooks.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,9 @@ def verify_toolchains_supported_by_eessi_version(easyconfigs):
180180
# if it is a system toolchain or appears in the list, we are all good
181181
if is_system_toolchain(toolchain['name']):
182182
continue
183+
# This check verifies that the toolchain dict is in the list of supported toolchains.
184+
# It uses <= as there may be other dict entries in the values returned from get_toolchain_hierarchy()
185+
# but we only care that the toolchain dict (which has 'name' and 'version') appear.
183186
elif not any(toolchain.items() <= supported.items() for supported in supported_eessi_toolchains):
184187
raise EasyBuildError(
185188
f"Toolchain {toolchain} (required by {ec['full_mod_name']}) is not supported in EESSI/{eessi_version}\n"

0 commit comments

Comments
 (0)