Apply suggestions from code review

Co-authored-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Martin Litre <mnlitre@gmail.com>

Author: mlitre

modules/EnergyManagement/EEBUS/manifest.yaml

@@ -9,25 +9,25 @@ config:
     type: integer
     default: 4715
   grpc_port:
-    description: Port for grpc control service connection. This is the port on which we will create our control service channel and start the grpc binary with.
+    description: Port for grpc control service connection. This is the port on which we will create our control service channel and start the grpc binary with, required/used when manage_eebus_grpc_api_binary=true
     type: integer
     default: 50051
   eebus_ems_ski:
     description: EEBUS EMS SKI
     type: string
     required: true
   certificate_path:
-    description: Path to the certificate file used by eebus go client. If relative will be prefixed with everest prefix + etc/everest/certs. Otherwise absolute file path is used.
+    description: Path to the certificate file used by eebus go client. If relative will be prefixed with everest prefix + etc/everest/certs. Otherwise absolute file path is used, required/used when manage_eebus_grpc_api_binary=true
     type: string
     required: false
     default: eebus/evse_cert
   private_key_path:
-    description: Path to the private key file used by eebus go client. If relative will be prefixed with everest prefix + etc/everest/certs. Otherwise absolute file path is used.
+    description: Path to the private key file used by eebus go client. If relative will be prefixed with everest prefix + etc/everest/certs. Otherwise absolute file path is used, required/used when manage_eebus_grpc_api_binary=true
     type: string
     required: false
     default: eebus/evse_key
   eebus_grpc_api_binary_path:
-    description: Path to the eebus grpc api binary. If relative will be prefixed with everest prefix + libexec. Otherwise absolute file path is used.
+    description: Path to the eebus grpc api binary. If relative will be prefixed with everest prefix + libexec. Otherwise absolute file path is used, required/used when manage_eebus_grpc_api_binary=true
     type: string
     required: false
     default: eebus_grpc_api
@@ -47,11 +47,11 @@ config:
     description: Serial number for the configuration of the control service
     type: string
     required: true
-  failsafe_control_limit:
+  failsafe_control_limit_W:
     description: Failsafe control limit for LPC use case. This will also be used for the default consumption limit, unit is Watts
     type: integer
     default: 4200
-  max_nominal_power:
+  max_nominal_power_W:
     description: Maximum nominal power of the charging station. This is the max power the CS can consume.
     type: integer
     default: 32000

tests/eebus_tests/fixtures/grpc_testing_server.py

@@ -47,4 +47,4 @@ async def cs_lpc_control_server(cs_lpc_control_servicer):
     server = cs_lpc_control_server_module.CsLpcControlServer(cs_lpc_control_servicer)
     await server.start()
     yield server
-    await server.stop()
+    await server.stop()

tests/eebus_tests/grpc_server/control_service_server.py

@@ -38,4 +38,4 @@ async def start(self):
         await self._server.start()
 
     async def stop(self):
-        await self._server.stop(0)
+        await self._server.stop(0)

tests/eebus_tests/grpc_server/cs_lpc_control_server.py

@@ -39,4 +39,4 @@ async def start(self):
         await self._server.start()
 
     async def stop(self):
-        await self._server.stop(0)
+        await self._server.stop(0)

tests/eebus_tests/grpc_servicer/common.py

@@ -26,4 +26,4 @@ async def default_command_func(self, request, context, command):
         response = await asyncio.wait_for(self.command_queues[command].response_queue.get(), timeout=30)
     except asyncio.TimeoutError:
         raise asyncio.TimeoutError(f"{command} response queue is empty, not able to get response")
-    return response
+    return response

tests/eebus_tests/grpc_servicer/cs_lpc_control_servicer.py

@@ -83,4 +83,4 @@ async def ConsumptionNominalMax(self, request, context):
         return await default_command_func(self, request, context, "ConsumptionNominalMax")
 
     async def SetConsumptionNominalMax(self, request, context):
-        return await default_command_func(self, request, context, "SetConsumptionNominalMax")
+        return await default_command_func(self, request, context, "SetConsumptionNominalMax")

tests/eebus_tests/helpers/async_helpers.py

@@ -10,4 +10,4 @@ async def async_get(q: asyncio.Queue, timeout: float = None):
     try:
         return await asyncio.wait_for(q.get(), timeout=timeout)
     except asyncio.TimeoutError:
-        raise TimeoutError(f"async_get timed out after {timeout} seconds")
+        raise TimeoutError(f"async_get timed out after {timeout} seconds")