fix(EvseV2G): Set Responsecode to FAULT if auth times out #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
requested review from
Pietfried,
SebaLukas,
hikinggrass,
james-ctc and
mlitre
as code owners
SebaLukas
approved these changes
Nov 28, 2025
FaHaGit
reviewed
Dec 1, 2025
| } else { | ||
| res->ResponseCode = iso2_responseCodeType_FAILED; | ||
| } | ||
| } else if (conn->ctx->session.authorization_rejected == true) { |
Contributor
There was a problem hiding this comment.
The handling of the "authorization_rejected" parameter is implemented slightly differently between DIN and ISO, if I understand correctly. In ISO, "authorization_rejected" is only evaluated if processing has been set to "finished". In DIN it is independed of the "evse_processing". Is that how it's intended to work? It will probably not make any difference, as the "evse_processing" is configured together with “authorization_rejected.”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If auth is revoked e.g. due to a plugin timeout, set the ISO-2/DIN response code to FAILED instead of OK.
Issue ticket number and link
Checklist before requesting a review