Skip to content

Explanation for failing dissolved inorganic carbon in carbon test "test_changed_kbod_20" #90

@imscw95

Description

@imscw95

The RAS WQ modules are being used to set the "correct" values for each nsm calculation. In the case of computing the updated DIC value when changing the kbod_20 value, the RAS value at timestep = 1 appears to match the NSM value at timestep = 2. This is due to the fact that the CBOD_oxidation (= DOX_CBOD_oxidation in NSM) is set = to nan in NSM but set equal to a computed value in RAS at timestep = 1. This leads to the DIC values offsetting by one timestep. There appears to be other error between computed DIC values, likely due to other less influential parameters having different values due to the offset timestep.

CBOD_oxidation values:
RAS
image
NSM
image

DIC values:
RAS
image
NSM
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingnsmSpecific to NSM moduletestsRelating to our pytest suite

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions