Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

No use of Routes in App.js #45

Open
Yuvrajhere opened this issue Apr 6, 2021 · 2 comments
Open

No use of Routes in App.js #45

Yuvrajhere opened this issue Apr 6, 2021 · 2 comments

Comments

@Yuvrajhere
Copy link
Member

Yuvrajhere commented Apr 6, 2021

Describe the bug
The BrowserRouter is imported and used in index.js but no Routes are being used to render specific Components in App.js , which leads to same render for all the routes. Also, because of this, the component not-found never renders for unknown urls.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'localhost:3000/'
  2. This should render the home-page component.
  3. But because of no Routes being used, going to 'localhost:3000/any-string' still renders the home-page and does not render not-found component.

Expected behavior
Going to localhost:3000/ should render home-page component and for all other unknown routes like 'localhost:3000/example' should render not-found component.

Screenshots
Screenshot (481)
See the URL.

Desktop (please complete the following information):

  • OS: [Windows 10 home, any]
  • Browser [Chrome, any]
  • Version [89.0.4389.114, any]

Smartphone (please complete the following information):

  • Device: [any]
  • OS: [any]
  • Browser [any]
  • Version [any]
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@eddiejaoude
Copy link
Member

Thank you @Yuvrajhere for raising the issue 👍 , I think this repo will need a reboot when we get to it. We are currently focusing on the API repo https://github.com/EddieHubCommunity/api

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants