This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
feat: improve accessibility of the project #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi! Quick Question: Does this fix everything apart from the Element 6 (the one in the iframe)? |
kkrishguptaa
changed the title
|
Yes,the errors from "Elements must meet minimum color contrast ratio thresholds to meet the WCAG 2 AA" that are not related to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #302
Changes proposed
One of the suggested changes is related to a
<iframe>element which cannot be change within the Application,therefore is not changed.Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
After picking up the issue i have to admit it took a minute until i can track the exact texts that need a change.
With these changes I do believe the text looks better and is way more readable.