Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Make it clear that the package.json and package-lock.json Should not be committed #26

Open
NS007-dev opened this issue Nov 5, 2021 · 8 comments

Comments

@NS007-dev
Copy link
Member

I have seen in some pull requests that the package.json is being committed as well, maybe it should be in the .gitignore files or should made clear to not add the package files.
Thank you.

@eddiejaoude
Copy link
Member

We should make this clear not to commit, these should not be ignored otherwise people cannot install in the dependencies

@mohan-murali
Copy link

yes otherwise their might be different version of packages installed for different people.

@NS007-dev
Copy link
Member Author

We should make this clear not to commit, these should not be ignored otherwise people cannot install in the dependencies

Yes I agree

@NS007-dev
Copy link
Member Author

I will change the issue name.
Thank you

@NS007-dev NS007-dev changed the title Move package.json and package-lock.json to .gitignore Make it clear that the package.json and package-lock.json Should not be committed Nov 6, 2021
@eddiejaoude
Copy link
Member

thank you 👍

@gptkrsh
Copy link

gptkrsh commented Nov 20, 2021

Is this to be added in the readme?

@NS007-dev
Copy link
Member Author

Yes, I think that is where it should be said @krishguptadev

@gptkrsh
Copy link

gptkrsh commented Nov 21, 2021

I think we should wait for the contributing.md file and add it there instead. Thanks 😊👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants