This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 43
Make it clear that the package.json
and package-lock.json
Should not be committed
#26
Comments
We should make this clear not to commit, these should not be ignored otherwise people cannot install in the dependencies |
yes otherwise their might be different version of packages installed for different people. |
Yes I agree |
I will change the issue name. |
NS007-dev
changed the title
Move
Make it clear that the Nov 6, 2021
package.json
and package-lock.json
to .gitignore
package.json
and package-lock.json
Should not be committed
thank you 👍 |
Is this to be added in the readme? |
Yes, I think that is where it should be said @krishguptadev |
I think we should wait for the contributing.md file and add it there instead. Thanks 😊👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have seen in some pull requests that the package.json is being committed as well, maybe it should be in the .gitignore files or should made clear to not add the package files.
Thank you.
The text was updated successfully, but these errors were encountered: