Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Pull Requests fail because Forks do not have access to the Repo's "Secrets" #25

Open
eddiejaoude opened this issue Sep 6, 2020 · 7 comments
Open

Pull Requests fail because Forks do not have access to the Repo's "Secrets" #25

eddiejaoude opened this issue Sep 6, 2020 · 7 comments

Comments

@eddiejaoude
Copy link
Member

eddiejaoude commented Sep 6, 2020 •
edited
Loading

  • How can we get round this?
  • Alternative options
    • Save stats in a json file instead of the DB - but will make having badges on an API more challenging (could then have another action to update the DB once the PR is merged to develop 🤷‍♂️
    • Try not to run the Action for forks PRs - not sure how that will effect stats

Screenshot 2020-09-06 at 08 51 11
@eddiejaoude eddiejaoude changed the title Pull Requests fail due to not having the Repo's "Secrets" Pull Requests fail because Forks do not have access to the Repo's "Secrets" Sep 6, 2020
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): no stats for fork #25
878fd72
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): custom comments action #25
ab30aca
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): use develop branch for now #25
62c19d9
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): docs to trigger build #25
248d43d
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(multiple): required action inputs #25
e9c34e0
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(multiple): Action trigger events #25
add133a
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(multiple): Checkout code #25
ee477be
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(multiple): Typo fix variable name #25
8cdad16
@eddiejaoude2
Copy link

helping test the action

eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): Changed event types #25
7ab6fbf
eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(fork): Changed event types #25
c67e088
@BhuvaneshHingal
Copy link
Member

Helping to test the GitHub Action

@ghost
Copy link

ghost commented Sep 6, 2020

Helping to test the Github Action.

@eddiejaoude
Copy link
Member Author

thank you @BhuvaneshHingal and @karenefereyan

eddiejaoude added a commit that referenced this issue Sep 6, 2020
@eddiejaoude
fix(action): condition might not be required #25
b16f916
@github-actions
Copy link

github-actions bot commented Nov 6, 2020

Stale issue message

@naomi-lgbt naomi-lgbt mentioned this issue Nov 17, 2020
Closed
@Vyvy-vi
Copy link
Member

Vyvy-vi commented Nov 17, 2020

can we perhaps use dummy-variables for forks?
(or use cache?)

@eddiejaoude
Copy link
Member Author

I think GitHub released a config fix for this. I can not remember what it is though. We will have to look it up

@Vyvy-vi Vyvy-vi mentioned this issue Dec 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddiejaoude @eddiejaoude2 @BhuvaneshHingal @Vyvy-vi