Windows support

[daniel-rikowski]

Currently vite_ruby doesn't work on Windows. This is due to resolveEntrypointFiles not finding any files, which is caused by:

1. path.resolve returning paths in the OS-native format (i.e. on Windows with \ as path separator)
2. fast-glob requiring glob patterns to use only / as path separator

Changing this

const resolvedGlobs = resolveGlobs(projectRoot, sourceCodeDir, inputGlobs)

into this

const resolvedGlobs = resolveGlobs(projectRoot, sourceCodeDir, inputGlobs).map((pattern) => pattern.replace(/\\/g, '/'))

makes vite_ruby work on Windows. (at least it looks that way 🙏 )

I can make a pull request, but since the change is trivial - and perhaps too trivial - I'd like to discuss it first 🤞

[ElMassimo]

Hi Daniel! Thanks for sharing!

Would you be willing to test a pre-release of vite-plugin-ruby with the suggested fix?

@daniel-rikowski Released as [email protected]

[daniel-rikowski]

I tried but it doesn't work. Now resolveGlobs returns this:

[
 "C:\Projects\MyProject/C:/Projects/MyProject/C:\Projects\MyProject\app\frontend/entrypoints/**/*",
 "C:\Projects\MyProject/C:/Projects/MyProject/C:\Projects\MyProject\app\frontend/{assets,fonts,icons,images}/**/*",
]

with

projectRoot = "C:\Projects\MyProject"
sourceCodeDir = "C:\Projects\MyProject\app\frontend"

It looks like both parameters to path.posix.resolve get prepended with the current working directory.

This might be related to a long-standing bug in node regarding path.posix. (nodejs/node#13887)
I'm using node 14.18.0 where it should be fixed, but perhaps this is caused by something else.

Both of these lines work, though:

slash(path.win32.resolve(projectRoot, pattern.replace(/^~\//, `${sourceCodeDir}/`)))
slash(path.resolve(projectRoot, pattern.replace(/^~\//, `${sourceCodeDir}/`)))

[ElMassimo]

Thanks for testing it, used the second line of your example, it's now released as [email protected].

sourceCodeDir should be relative to the root and use POSIX separators: app/frontend.

[daniel-rikowski]

It works now! Thank you for the quick response!

[ElMassimo]

I'll make a 3.0.2 release during the week.

Thanks for reporting and helping with the fix! 😃