hsm_secret: fixup! make read_line tidier

Author: sangbida

common/hsm_secret.c

@@ -401,8 +401,8 @@ static char *read_line(const tal_t *ctx)
 
 	/* Strip newline */
 	size_t len = strlen(line);
-	if (len > 0 && line[len - 1] == '\n')
-		line[len - 1] = '\0';
+	if (strends(line, "\n"))
+		len--;
 
 	/* Convert to tal string */
 	char *result = tal_strndup(ctx, line, len);
@@ -426,7 +426,7 @@ const char *read_stdin_pass(const tal_t *ctx, enum hsm_secret_error *err)
 		*err = HSM_SECRET_ERR_INVALID_FORMAT;
 		return NULL;
 	}
-	
+
 	mlock_tal_memory(input);
 
 	if (echo_disabled)

wallet/test/run-chain_moves_duplicate-detect.c

@@ -28,6 +28,9 @@ static void db_log_(struct logger *log UNUSED, enum log_level level UNUSED, cons
 /* Generated stub for bip32_pubkey */
 void bip32_pubkey(struct lightningd *ld UNNEEDED, struct pubkey *pubkey UNNEEDED, u32 index UNNEEDED)
 { fprintf(stderr, "bip32_pubkey called!\n"); abort(); }
+/* Generated stub for bip86_pubkey */
+void bip86_pubkey(struct lightningd *ld UNNEEDED, struct pubkey *pubkey UNNEEDED, u32 index UNNEEDED)
+{ fprintf(stderr, "bip86_pubkey called!\n"); abort(); }
 /* Generated stub for bitcoind_getrawblockbyheight_ */
 void bitcoind_getrawblockbyheight_(const tal_t *ctx UNNEEDED,
 				   struct bitcoind *bitcoind UNNEEDED,

wallet/test/run-migrate_remove_chain_moves_duplicates.c

@@ -29,6 +29,9 @@ static void db_log_(struct logger *log UNUSED, enum log_level level UNUSED, cons
 /* Generated stub for bip32_pubkey */
 void bip32_pubkey(struct lightningd *ld UNNEEDED, struct pubkey *pubkey UNNEEDED, u32 index UNNEEDED)
 { fprintf(stderr, "bip32_pubkey called!\n"); abort(); }
+/* Generated stub for bip86_pubkey */
+void bip86_pubkey(struct lightningd *ld UNNEEDED, struct pubkey *pubkey UNNEEDED, u32 index UNNEEDED)
+{ fprintf(stderr, "bip86_pubkey called!\n"); abort(); }
 /* Generated stub for bitcoind_getrawblockbyheight_ */
 void bitcoind_getrawblockbyheight_(const tal_t *ctx UNNEEDED,
 				   struct bitcoind *bitcoind UNNEEDED,