Skip to content

Commit a2eb931

Browse files
authored
Fix string truncation (#36)
* Fix string truncation * Update CI * Update deny * Add single join job * Update CHANGELOG
1 parent 7e0eca4 commit a2eb931

File tree

6 files changed

+1252
-25
lines changed

6 files changed

+1252
-25
lines changed

.github/workflows/rust-ci.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
name: Lint
1717
runs-on: ubuntu-22.04
1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
- uses: dtolnay/rust-toolchain@stable
2121
with:
2222
components: "clippy, rustfmt"
@@ -35,10 +35,10 @@ jobs:
3535
name: Test
3636
strategy:
3737
matrix:
38-
os: [ubuntu-22.04, windows-2022, macOS-12]
38+
os: [ubuntu-22.04, windows-2022, macOS-14]
3939
runs-on: ${{ matrix.os }}
4040
steps:
41-
- uses: actions/checkout@v3
41+
- uses: actions/checkout@v4
4242
- uses: dtolnay/rust-toolchain@stable
4343
- uses: Swatinem/rust-cache@v2
4444
- run: cargo fetch
@@ -51,16 +51,22 @@ jobs:
5151
name: cargo-deny
5252
runs-on: ubuntu-22.04
5353
steps:
54-
- uses: actions/checkout@v3
54+
- uses: actions/checkout@v4
5555
- uses: EmbarkStudios/cargo-deny-action@v1
5656

5757
publish-check:
5858
name: Publish Check
5959
runs-on: ubuntu-22.04
6060
steps:
61-
- uses: actions/checkout@v3
61+
- uses: actions/checkout@v4
6262
- uses: dtolnay/rust-toolchain@stable
6363
- uses: Swatinem/rust-cache@v2
6464
- run: cargo fetch
6565
- name: cargo publish check
6666
run: cargo publish --dry-run --manifest-path sdk/Cargo.toml
67+
68+
test_success:
69+
runs-on: ubuntu-22.04
70+
needs: [lint,test,publish-check,deny-check]
71+
steps:
72+
- run: echo "All test jobs passed"

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
<!-- markdownlint-disable blanks-around-headers no-duplicate-header blanks-around-lists -->
8+
<!-- markdownlint-disable blanks-around-headings no-duplicate-heading blanks-around-lists -->
99

1010
<!-- next-header -->
1111
## [Unreleased] - ReleaseDate
12+
### Fixed
13+
- [PR#36](https://github.com/EmbarkStudios/discord-sdk/pull/36) fixed [#35](https://github.com/EmbarkStudios/discord-sdk/issues/35) by properly truncating utf-8 strings.
14+
1215
## [0.3.5] - 2023-10-04
1316
### Changed
1417
- [PR#34](https://github.com/EmbarkStudios/discord-sdk/pull/34) replaced `base64` with `data-encoding`.

0 commit comments

Comments
 (0)