Skip to content

Commit 1f5825a

Browse files
authored
externalize credentials (#8)
* delete credentials.py and credentials example * update BinanceManager and .gitignore
1 parent d30a7c5 commit 1f5825a

File tree

4 files changed

+2
-38
lines changed

4 files changed

+2
-38
lines changed

.gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ dmypy.json
141141
# except README
142142
!**/README.md
143143

144-
# except credentials example
145-
!data/credentials.json.example
146144

147145
# except gitkeep
148146
!**/.gitkeep

data/credentials.json.example

-9
This file was deleted.

src/storage/BinanceManager.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
from src.utils.time_utils import datetime_to_millistamp
1010
from src.storage.BinanceDataBase import BinanceDataBase
11-
from src.utils.credentials import CredentialManager
1211
from src.storage import tables
1312

1413

@@ -17,10 +16,9 @@ class BinanceManager:
1716
This class is in charge of filling the database by calling the binance API
1817
"""
1918

20-
def __init__(self):
19+
def __init__(self, api_key: str, api_secret: str):
2120
self.db = BinanceDataBase()
22-
credentials = CredentialManager.get_api_credentials("Binance")
23-
self.client = Client(**credentials)
21+
self.client = Client(api_key=api_key, api_secret=api_secret)
2422

2523
def update_universal_transfers(self):
2624
"""

src/utils/credentials.py

-23
This file was deleted.

0 commit comments

Comments
 (0)