Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not helpful error message when reverting commit with conflicts #32

Open
Exelord opened this issue Oct 16, 2022 · 2 comments
Open

Not helpful error message when reverting commit with conflicts #32

Exelord opened this issue Oct 16, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Exelord
Copy link
Owner

Exelord commented Oct 16, 2022

Screen Shot 2022-10-16 at 20 35 44

This error should be caught and replaced with info about conflicts during commit revert
@Exelord Exelord changed the title Not helpful error when reverting commit with conflicts Not helpful error message when reverting commit with conflicts Oct 16, 2022
@Exelord Exelord added bug Something isn't working good first issue Good for newcomers labels Oct 16, 2022
@Regenhardt
Copy link

Is this the place that needs an error check? Maybe I'll work on that. Haven't worked with vscode extensions before, will be a learning experience.

@Exelord
Copy link
Owner Author

Exelord commented Jul 7, 2023

Hey :) Thank you for looking at that!
Possible it is the place. It could be replaced with GitManager I guess and somehow errors should be handled there.
I think right now all errors in git manager are suppressed or not displaying in UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Exelord @Regenhardt