Skip to content

Commit c5dc496

Browse files
Jason Bulicekashishagg
Jason Bulicek
authored andcommitted
fix bug with traceId not showing in dropdown (#481)
1 parent 29bf3d0 commit c5dc496

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/components/universalSearch/searchBar/autosuggest.jsx

+1
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ export default class Autocomplete extends React.Component {
132132
componentDidMount() {
133133
this.props.options.serviceName = {isRangeQuery: false, values: this.props.serviceStore.services};
134134
this.props.options.operationName = {isRangeQuery: false, values: []};
135+
this.props.options.traceId = {isRangeQuery: false, values: []};
135136

136137
// Automatically checks for operations when a user supplies a new serviceName
137138
when(() => this.props.serviceStore.services.length,

test/src/components/universalSearch/universalSearch.spec.jsx

+9-8
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ const stubHistory = {
4747
const stubOptions = {
4848
error: {values: ['true, false'], isRangeQuery: false},
4949
serviceName: {values: ['test-a', 'test-b', 'test-c', 'whitespace test'], isRangeQuery: false},
50-
operationName: {values: [], isRangeQuery: false}
50+
operationName: {values: [], isRangeQuery: false},
51+
traceId: {values: [], isRangeQuery: false}
5152
};
5253

5354

@@ -300,7 +301,7 @@ describe('<Autosuggest />', () => {
300301
expect(wrapper.instance().state.suggestionStrings.length).to.equal(0);
301302
const input = wrapper.find('.usb-searchbar__input');
302303
input.prop('onFocus')({target: {value: ''}});
303-
expect(wrapper.instance().state.suggestionStrings.length).to.equal(3);
304+
expect(wrapper.instance().state.suggestionStrings.length).to.equal(4);
304305
});
305306

306307
it('update suggestion string index on suggestion mouseover', () => {
@@ -312,7 +313,7 @@ describe('<Autosuggest />', () => {
312313
const firstSuggestion = wrapper.find('.usb-suggestions__field').last();
313314
firstSuggestion.simulate('mouseEnter');
314315

315-
expect(wrapper.instance().state.suggestionIndex).to.equal(2);
316+
expect(wrapper.instance().state.suggestionIndex).to.equal(3);
316317
});
317318

318319
it('update suggestion string index on suggestion mouseover', () => {
@@ -375,7 +376,7 @@ describe('<Autosuggest />', () => {
375376
expect(wrapper.instance().state.suggestedOnType).to.equal('Keys');
376377

377378
input.prop('onKeyDown')({keyCode: 38, preventDefault: () => {}});
378-
expect(wrapper.instance().state.suggestionIndex).to.equal(2);
379+
expect(wrapper.instance().state.suggestionIndex).to.equal(3);
379380
expect(wrapper.instance().state.suggestedOnType).to.equal('Keys');
380381

381382
input.prop('onKeyDown')({keyCode: 13, preventDefault: () => {}});
@@ -429,16 +430,16 @@ describe('<Autosuggest />', () => {
429430
const input = wrapper.find('.usb-searchbar__input');
430431
input.prop('onFocus')({target: {value: ''}});
431432
input.prop('onKeyDown')({keyCode: 38, preventDefault: () => {}});
432-
expect(wrapper.instance().state.suggestionIndex).to.equal(2);
433+
expect(wrapper.instance().state.suggestionIndex).to.equal(3);
433434
input.prop('onKeyDown')({keyCode: 38, preventDefault: () => {}});
434-
expect(wrapper.instance().state.suggestionIndex).to.equal(1);
435+
expect(wrapper.instance().state.suggestionIndex).to.equal(2);
435436
input.prop('onKeyDown')({keyCode: 38, preventDefault: () => {}});
436-
expect(wrapper.instance().state.suggestionIndex).to.equal(0);
437-
input.prop('onKeyDown')({keyCode: 40, preventDefault: () => {}});
438437
expect(wrapper.instance().state.suggestionIndex).to.equal(1);
439438
input.prop('onKeyDown')({keyCode: 40, preventDefault: () => {}});
440439
expect(wrapper.instance().state.suggestionIndex).to.equal(2);
441440
input.prop('onKeyDown')({keyCode: 40, preventDefault: () => {}});
441+
expect(wrapper.instance().state.suggestionIndex).to.equal(3);
442+
input.prop('onKeyDown')({keyCode: 40, preventDefault: () => {}});
442443
expect(wrapper.instance().state.suggestionIndex).to.equal(0);
443444
});
444445

0 commit comments

Comments
 (0)