No notifications for entity deletion

[pdmangel2]

Referring to #1307 and release notes :
I'm using orion-ld 1.3.0 and I'm not getting notification when entities are deleted.

[kzangeli]

You are probably not running the broker in the "new" mode.
The option to turn that on is called "-experimental" and I need to change that name.
It was experimental, more than a year ago.

[pdmangel2]

even with -experimental I don't get them

the subscription for notifications (in mongodb)

{
    "_id" : "gspt:subscr:parktrack-api:entityCache:f82ac802-9d41-4e4a-b2bb-e73bf1d9e8c6",
    "description" : "parktrack-api entityCache  parkingzone updates",
    "entities" : [
        {
            "type" : "https://uri.etsi.org/ngsi-ld/default-context/ParkingGroup",
            "id" : ".*",
            "isPattern" : "true",
            "isTypePattern" : false
        }
    ],
    "ldQ" : "https://uri=etsi=org/ngsi-ld/default-context/gsApplicationType.value==%22ParkingZone%22",
    "createdAt" : 1705414833.2422335,
    "modifiedAt" : 1705414833.2422335,
    "throttling" : NumberInt(0),
    "expression" : {
        "geometry" : "",
        "coords" : "",
        "georel" : "",
        "geoproperty" : "",
        "q" : "https://uri=etsi=org/ngsi-ld/default-context/gsApplicationType.value==%22ParkingZone%22",
        "mq" : ""
    },
    "reference" : "http://nginx:8080/api/parktrack/entityCache/ngsiLDEntityUpdates",
    "mimeType" : "application/json",
    "attrs" : [

    ],
    "format" : "normalized",
    "conditions" : [

    ],
    "status" : "active",
    "custom" : false,
    "servicePath" : "/#",
    "blacklist" : false,
    "ldContext" : "https://uri.etsi.org/ngsi-ld/v1/ngsi-ld-core-context.jsonld"
}

[kzangeli]

ok, that is weird.
Pretty sure I implemented that ...
In a meeting right now. Will look at this asap

[kzangeli]

ok, I just understood what's failing here.
I have a functest making sure the notifications for DELETE arrive.

BUT, that functest is not very complete.
For example, it doesn't include a subscription with a "q".
And that's the bug. I just tested it, modifying my functest (adding a "q" to one of the subscriptions).
It fails, because apparently I include the "q" as a filter also for DELETE operations when I match entity modifications with subscriptions. That's obviously a mistake, and the culprit to the bug you've found.

Should be an easy fix. Stay tuned ... :)

[kzangeli]

PR merged.
Please try with the new docker image and close this issue if it's working as it should.

[pdmangel2]

Thanks for the quick update Ken.
I'm getting an update message ... but twice. Can you confirm this ?

[kzangeli]

You get two notifications of the Deletion?
That would only (hopefully) happen if you have two subscriptions ...

[pdmangel2]

I checked and I have a single subscription.
Also updates are coming only once.

[kzangeli]

Ah ok, all good then :)

[pdmangel2]

Sorry ... creation and updates are coming once, deletions twice :-(

[kzangeli]

Hmm, ok, I'll have to look into that, see if I can reproduce it.
Just that subscription from above and you delete a matching entity, right?

[pdmangel2]

indeed