Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateIntermediary: Names Not Generated For Fields With Length Greater Than 2 #43

Open
gudenau opened this issue Aug 17, 2022 · 2 comments

Comments

@gudenau
Copy link

gudenau commented Aug 17, 2022

I found this when generating mappings for an obfuscated jar that uses "banned" names such as float, false or COM1. These longer names are getting skipped and passed though normally.

The culprit appears to be here:

public static boolean isUnmappedFieldName(String name) {
return name.length() <= 2 || (name.length() == 3 && name.charAt(2) == '_');
}

@Juuxel
Copy link
Member

Juuxel commented Aug 17, 2022

#34 could help with this I think

@gudenau
Copy link
Author

gudenau commented Aug 17, 2022

It would appear as though that accidentally solves this, hopefully that can be pulled soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants