Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding configurations for alert thresholds with annotations does not work #175

Open
sylon23 opened this issue Jun 2, 2021 · 2 comments
Labels
pinned Prevents stalebot from removing

Comments

@sylon23
Copy link

sylon23 commented Jun 2, 2021

Context

Based on the documentation here overriding alert configurations with the field "threshold-critical" does not work.

Process

  • Created a custom monitor (apdex-alert) in configuration file
  • Added annotations to override monitor name, query, and message in a Kubernetes deployment and there are no logged errors for these.
  • Added annotation to override alert threshold in the same deployment- "astro.fairwinds.com/override.apdex-alert.threshold-critical: 0.80"

Expected Result

  • Monitor is created
  • Newly created monitor reflects the new values

Current Result

  • Monitor is not created.
  • The following can be seen in the logs

time="2021-06-02T15:55:58Z" level=warning msg="override provided does mot match any monitor fields. provided field: threshold-critical"

Please help fix or suggest any necessary modifications.

@lucasreed
Copy link
Contributor

Thanks for bringing this to our attention! We will do our best to take look at this ASAP but our time has been a bit limited on this project. Thanks for being understanding!

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label Jul 21, 2021
@lucasreed lucasreed added the pinned Prevents stalebot from removing label Jul 21, 2021
@stale stale bot removed the stale Marked as stale by stalebot label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Prevents stalebot from removing
Projects
None yet
Development

No branches or pull requests

2 participants