make overflow fix more flexible

FarisZR · FarisZR · commit fce882d28d80 · 2025-11-01T16:39:03.000+01:00
diff --git a/internal/journald/journald.go b/internal/journald/journald.go
@@ -3,6 +3,7 @@ package journald
 import (
 	"errors"
 	"fmt"
+	"math"
 	"sync/atomic"
 	"syscall"
 )
@@ -32,7 +33,6 @@ const (
 	// journald entries.
 	SchemaVersion     = "1"
 	defaultIdentifier = "knocker"
-	maxFieldsCount    = 1024
 )
 
 // Enabled reports whether structured journald logging is available on the
@@ -51,8 +51,8 @@ func Emit(eventType, message string, priority Priority, fields Fields) error {
 		return nil
 	}
 
-	if len(fields) > maxFieldsCount {
-		return fmt.Errorf("too many fields in journald entry: %d > %d", len(fields), maxFieldsCount)
+	if len(fields) > math.MaxInt-3 {
+		return fmt.Errorf("too many fields in journald entry: %d > %d", len(fields), math.MaxInt-3)
 	}
 
 	payload := make(Fields, len(fields)+3)

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ package journald`
`3`	`3`	`import (`
`4`	`4`	`"errors"`
`5`	`5`	`"fmt"`
	`6`	`+ "math"`
`6`	`7`	`"sync/atomic"`
`7`	`8`	`"syscall"`
`8`	`9`	`)`
`@@ -32,7 +33,6 @@ const (`
`32`	`33`	`// journald entries.`
`33`	`34`	`SchemaVersion = "1"`
`34`	`35`	`defaultIdentifier = "knocker"`
`35`		`- maxFieldsCount = 1024`
`36`	`36`	`)`
`37`	`37`
`38`	`38`	`// Enabled reports whether structured journald logging is available on the`
`@@ -51,8 +51,8 @@ func Emit(eventType, message string, priority Priority, fields Fields) error {`
`51`	`51`	`return nil`
`52`	`52`	`}`
`53`	`53`
`54`		`- if len(fields) > maxFieldsCount {`
`55`		`- return fmt.Errorf("too many fields in journald entry: %d > %d", len(fields), maxFieldsCount)`
	`54`	`+ if len(fields) > math.MaxInt-3 {`
	`55`	`+ return fmt.Errorf("too many fields in journald entry: %d > %d", len(fields), math.MaxInt-3)`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`payload := make(Fields, len(fields)+3)`