[ref] global: refactore to follow cppcoreguidelines

Refactored the code to follow the cppcoreguidelines defined in the clang-tidy conf file. Several checks are failing due to qApp casting inside qapplication.

Author: bgallois

.clang-tidy

@@ -0,0 +1,88 @@
+---
+Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,clang-*,cppcoreguidelines-avoid-c-arrays,cppcoreguidelines-avoid-goto,cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-c-copy-assignment-signature,cppcoreguidelines-explicit-virtual-functions,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-macro-usage,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-no-malloc,cppcoreguidelines-prefer-member-initializer,cppcoreguidelines-pro-bounds-*,cppcoreguidelines-pro-type-const-cast,cppcoreguidelines-pro-type-reinterpret-cast,cppcoreguidelines-pro-type-static-cast-downcast,cppcoreguidelines-pro-type-union-access,cppcoreguidelines-pro-type-vararg,cppcoreguidelines-slicing,cppcoreguidelines-special-member-functions'
+WarningsAsErrors: ''
+HeaderFilterRegex: ''
+AnalyzeTemporaryDtors: false
+FormatStyle:     none
+User:            bgallois
+CheckOptions:
+  - key:             modernize-loop-convert.MinConfidence
+    value:           reasonable
+  - key:             modernize-replace-auto-ptr.IncludeStyle
+    value:           llvm
+  - key:             cppcoreguidelines-no-malloc.Reallocations
+    value:           '::realloc'
+  - key:             cppcoreguidelines-special-member-functions.AllowMissingMoveFunctionsWhenCopyIsDeleted
+    value:           'false'
+  - key:             google-readability-namespace-comments.ShortNamespaceLines
+    value:           '10'
+  - key:             google-readability-namespace-comments.SpacesBeforeComments
+    value:           '2'
+  - key:             cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
+    value:           'true'
+  - key:             cert-dcl16-c.NewSuffixes
+    value:           'L;LL;LU;LLU'
+  - key:             cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
+    value:           'false'
+  - key:             modernize-loop-convert.MaxCopySize
+    value:           '16'
+  - key:             cppcoreguidelines-narrowing-conversions.WarnOnIntegerNarrowingConversion
+    value:           'true'
+  - key:             cppcoreguidelines-no-malloc.Allocations
+    value:           '::malloc;::calloc'
+  - key:             cppcoreguidelines-special-member-functions.AllowMissingMoveFunctions
+    value:           'false'
+  - key:             cppcoreguidelines-prefer-member-initializer.UseAssignment
+    value:           'false'
+  - key:             cppcoreguidelines-macro-usage.CheckCapsOnly
+    value:           'false'
+  - key:             cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
+    value:           'true'
+  - key:             cppcoreguidelines-pro-bounds-constant-array-index.GslHeader
+    value:           ''
+  - key:             cppcoreguidelines-explicit-virtual-functions.FinalSpelling
+    value:           final
+  - key:             llvm-qualified-auto.AddConstToQualified
+    value:           'false'
+  - key:             modernize-loop-convert.NamingStyle
+    value:           CamelCase
+  - key:             google-readability-function-size.StatementThreshold
+    value:           '800'
+  - key:             llvm-else-after-return.WarnOnConditionVariables
+    value:           'false'
+  - key:             cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes
+    value:           ''
+  - key:             modernize-pass-by-value.IncludeStyle
+    value:           llvm
+  - key:             cert-str34-c.DiagnoseSignedUnsignedCharComparisons
+    value:           'false'
+  - key:             cppcoreguidelines-explicit-virtual-functions.AllowOverrideAndFinal
+    value:           'false'
+  - key:             google-readability-braces-around-statements.ShortStatementLines
+    value:           '1'
+  - key:             cppcoreguidelines-explicit-virtual-functions.OverrideSpelling
+    value:           override
+  - key:             cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+    value:           'false'
+  - key:             modernize-use-nullptr.NullMacros
+    value:           'NULL'
+  - key:             cppcoreguidelines-no-malloc.Deallocations
+    value:           '::free'
+  - key:             cppcoreguidelines-macro-usage.IgnoreCommandLineMacros
+    value:           'true'
+  - key:             cppcoreguidelines-pro-bounds-constant-array-index.IncludeStyle
+    value:           llvm
+  - key:             cppcoreguidelines-macro-usage.AllowedRegexp
+    value:           '^DEBUG_*'
+  - key:             cppcoreguidelines-narrowing-conversions.WarnWithinTemplateInstantiation
+    value:           'false'
+  - key:             cppcoreguidelines-narrowing-conversions.PedanticMode
+    value:           'false'
+  - key:             cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion
+    value:           'true'
+  - key:             llvm-else-after-return.WarnOnUnfixable
+    value:           'false'
+  - key:             cppcoreguidelines-narrowing-conversions.WarnOnEquivalentBitWidth
+    value:           'true'
+...
+

src/annotation.cpp

@@ -82,7 +82,7 @@ Annotation::Annotation(const QString &filePath) : Annotation() {
 /**
  * @brief Constructs the annotation object from a file path.
  */
-Annotation::Annotation(QWidget *parent) : annotationFile{new QFile()}, annotations{new QMap<int, QString>()}, isActive{false} {
+Annotation::Annotation(QWidget *parent) : annotationFile{new QFile()}, annotations{new QMap<int, QString>()}, findIndex{-1}, isActive{false} {
 }
 
 /**

src/annotation.h

@@ -20,7 +20,7 @@ class Annotation : public QWidget {
   QMap<int, QString> *annotations;
   void writeToFile();
   QList<int> findIndexes;
-  int findIndex;
+  qsizetype findIndex;
 
  public slots:
   void clear();
@@ -42,6 +42,8 @@ class Annotation : public QWidget {
   Annotation(const QString &annotationFile);
   Annotation(const Annotation &T) = delete;
   Annotation &operator=(const Annotation &T) = delete;
+  Annotation &operator=(Annotation &&T) = delete;
+  Annotation(Annotation &&T) = delete;
   ~Annotation();
   bool setPath(const QString &annotationFile);
   bool isActive;

src/autolevel.h

@@ -50,6 +50,8 @@ class AutoLevel : public QObject {
   AutoLevel(const string &path, const UMat &background, const QMap<QString, QString> &parameters);
   AutoLevel(const AutoLevel &T) = delete;
   AutoLevel &operator=(const AutoLevel &T) = delete;
+  AutoLevel &operator=(AutoLevel &&T) = delete;
+  AutoLevel(AutoLevel &&T) = delete;
   static double stdev(const QList<double> &vect);
 
  public slots:

src/batch.cpp

@@ -42,7 +42,8 @@ using namespace std;
  * @brief Constructs the Batch widget.
  */
 Batch::Batch(QWidget *parent) : QWidget(parent),
-                                ui(new Ui::Batch) {
+                                ui(new Ui::Batch),
+                                currentPathCount(0) {
   ui->setupUi(this);
 
   // Setup the ui
@@ -229,7 +230,6 @@ Batch::Batch(QWidget *parent) : QWidget(parent),
 
   // Setups the path panel
   ui->tablePath->horizontalHeader()->setStretchLastSection(true);
-  currentPathCount = 0;
   ui->tablePath->setSortingEnabled(false);
   ui->tablePath->horizontalHeader()->setSectionResizeMode(QHeaderView::Interactive);
   connect(ui->openPath, &QPushButton::clicked, this, &Batch::openPathFolder);

src/batch.h

@@ -52,6 +52,11 @@ class Batch : public QWidget {
 
  public:
   explicit Batch(QWidget *parent = nullptr);
+  Batch(const Batch &T) = delete;
+  Batch &operator=(const Batch &T) = delete;
+  Batch &operator=(Batch &&T) = delete;
+  Batch(Batch &&T) = delete;
+
   ~Batch();
 
  private:

src/data.cpp

@@ -88,8 +88,7 @@ Data::Data(const QString &dataPath) : Data() {
 /**
  * @brief Construct the data object from a tracking result file.
  */
-Data::Data() : columns{"xHead", "yHead", "tHead", "xTail", "yTail", "tTail", "xBody", "yBody", "tBody", "curvature", "areaBody", "perimeterBody", "headMajorAxisLength", "headMinorAxisLength", "headExcentricity", "tailMajorAxisLength", "tailMinorAxisLength", "tailExcentricity", "bodyMajorAxisLength", "bodyMinorAxisLength", "bodyExcentricity", "imageNumber", "id"}, connectionName{QString("data_%1").arg(QRandomGenerator::global()->generate())} {
-  isEmpty = true;
+Data::Data() : columns{"xHead", "yHead", "tHead", "xTail", "yTail", "tTail", "xBody", "yBody", "tBody", "curvature", "areaBody", "perimeterBody", "headMajorAxisLength", "headMinorAxisLength", "headExcentricity", "tailMajorAxisLength", "tailMinorAxisLength", "tailExcentricity", "bodyMajorAxisLength", "bodyMinorAxisLength", "bodyExcentricity", "imageNumber", "id"}, connectionName{QString("data_%1").arg(QRandomGenerator::global()->generate())}, isEmpty{true} {
   QSqlDatabase data = QSqlDatabase::addDatabase(QStringLiteral("QSQLITE"), connectionName);
 }
 

src/data.h

@@ -33,6 +33,8 @@ class Data {
   explicit Data(const QString &dataPath);
   Data(const Data &T) = delete;
   Data &operator=(const Data &T) = delete;
+  Data &operator=(Data &&T) = delete;
+  Data(Data &&T) = delete;
   ~Data();
 
   const QString connectionName;

src/interactive.cpp

@@ -39,13 +39,13 @@ This file is part of Fast Track.
  * @brief Constructs the interactive object derived from a QMainWindow object.
  */
 Interactive::Interactive(QWidget *parent) : QMainWindow(parent),
-                                            ui(new Ui::Interactive) {
+                                            ui(new Ui::Interactive),
+                                            videoStatus(false) {
   ui->setupUi(this);
   ui->menuBar->setNativeMenuBar(false);
 
   // Loads settings
   QSettings settingsFile(QStringLiteral("FastTrack"), QStringLiteral("FastTrackOrg"));
-  videoStatus = false;
 
   // MetaType
   qRegisterMetaType<QMap<QString, double>>("QMap<QString, double>");
@@ -462,7 +462,7 @@ Interactive::Interactive(QWidget *parent) : QMainWindow(parent),
 
   // Set the image preview limits
   connect(ui->startImage, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), this, [this](int startImage) {
-    ui->stopImage->setRange(0, video->getImageCount() - startImage);
+    ui->stopImage->setRange(0, static_cast<int>(video->getImageCount()) - startImage);
   });
 
   // Events filter to zoom in/out in the display
@@ -539,12 +539,12 @@ void Interactive::openFolder() {
       memoryDir = dir;
       video->open(dir.toStdString());
       ui->slider->setMinimum(0);
-      ui->slider->setMaximum(video->getImageCount() - 1);
+      ui->slider->setMaximum(static_cast<int>(video->getImageCount()) - 1);
       ui->previewButton->setDisabled(true);
       ui->trackButton->setDisabled(true);
-      ui->nBack->setMaximum(video->getImageCount());
-      ui->nBack->setValue(video->getImageCount());
-      ui->startImage->setRange(0, video->getImageCount() - 1);
+      ui->nBack->setMaximum(static_cast<int>(video->getImageCount()));
+      ui->nBack->setValue(static_cast<int>(video->getImageCount()));
+      ui->startImage->setRange(0, static_cast<int>(video->getImageCount()) - 1);
       ui->startImage->setValue(0);
 
       Mat frame;
@@ -938,7 +938,7 @@ void Interactive::previewTracking() {
  */
 void Interactive::track() {
   if (videoStatus) {
-    ui->progressBar->setRange(0, video->getImageCount() - 1);
+    ui->progressBar->setRange(0, static_cast<int>(video->getImageCount()) - 1);
     ui->progressBar->setValue(0);
     ui->previewButton->setDisabled(true);
     ui->trackButton->setDisabled(true);
@@ -1003,25 +1003,25 @@ bool Interactive::eventFilter(QObject *target, QEvent *event) {
   if (target == ui->display) {
     // Set the first point for the ROI at user click
     if (event->type() == QEvent::MouseButtonPress) {
-      QMouseEvent *mouseEvent = static_cast<QMouseEvent *>(event);
+      QMouseEvent *mouseEvent = dynamic_cast<QMouseEvent *>(event);
       if (mouseEvent->buttons() == Qt::LeftButton) {
         clicks.first = mouseEvent->pos();
         // The QPixmap is V/Hcentered in the Qlabel widget
         // Gets the click coordinate in the frame of reference of the centered display
-        clicks.first.setX(static_cast<unsigned int>(clicks.first.x() - 0.5 * (ui->display->width() - resizedFrame.width())));
-        clicks.first.setY(static_cast<unsigned int>(clicks.first.y() - 0.5 * (ui->display->height() - resizedFrame.height())));
+        clicks.first.setX(static_cast<int>(clicks.first.x() - 0.5 * (ui->display->width() - resizedFrame.width())));
+        clicks.first.setY(static_cast<int>(clicks.first.y() - 0.5 * (ui->display->height() - resizedFrame.height())));
       }
     }
 
     // Sets the second point and draw the roi
     if (event->type() == QEvent::MouseMove) {
-      QMouseEvent *moveEvent = static_cast<QMouseEvent *>(event);
+      QMouseEvent *moveEvent = dynamic_cast<QMouseEvent *>(event);
       if (moveEvent->buttons() == Qt::LeftButton) {
         clicks.second = moveEvent->pos();
         // The QPixmap is V/Hcentered in the Qlabel widget
         // Gets the click coordinate in the frame of reference of the centered display
-        clicks.second.setX(static_cast<unsigned int>(clicks.second.x() - 0.5 * (ui->display->width() - resizedFrame.width())));
-        clicks.second.setY(static_cast<unsigned int>(clicks.second.y() - 0.5 * (ui->display->height() - resizedFrame.height())));
+        clicks.second.setX(static_cast<int>(clicks.second.x() - 0.5 * (ui->display->width() - resizedFrame.width())));
+        clicks.second.setY(static_cast<int>(clicks.second.y() - 0.5 * (ui->display->height() - resizedFrame.height())));
 
         // Draws the ROI with
         QPixmap tmpImage = resizedPix;
@@ -1065,21 +1065,21 @@ bool Interactive::eventFilter(QObject *target, QEvent *event) {
   if (target == ui->scrollArea->viewport()) {
     // Moves in the image by middle click
     if (event->type() == QEvent::MouseMove) {
-      QMouseEvent *moveEvent = static_cast<QMouseEvent *>(event);
+      QMouseEvent *moveEvent = dynamic_cast<QMouseEvent *>(event);
       if (moveEvent->buttons() == Qt::MiddleButton) {
-        ui->scrollArea->horizontalScrollBar()->setValue(static_cast<unsigned int>(ui->scrollArea->horizontalScrollBar()->value() + (panReferenceClick.x() - moveEvent->localPos().x())));
-        ui->scrollArea->verticalScrollBar()->setValue(static_cast<unsigned int>(ui->scrollArea->verticalScrollBar()->value() + (panReferenceClick.y() - moveEvent->localPos().y())));
+        ui->scrollArea->horizontalScrollBar()->setValue(static_cast<int>(ui->scrollArea->horizontalScrollBar()->value() + (panReferenceClick.x() - moveEvent->localPos().x())));
+        ui->scrollArea->verticalScrollBar()->setValue(static_cast<int>(ui->scrollArea->verticalScrollBar()->value() + (panReferenceClick.y() - moveEvent->localPos().y())));
         panReferenceClick = moveEvent->localPos();
       }
     }
     if (event->type() == QEvent::Wheel) {
-      QWheelEvent *wheelEvent = static_cast<QWheelEvent *>(event);
+      QWheelEvent *wheelEvent = dynamic_cast<QWheelEvent *>(event);
       zoomReferencePosition = wheelEvent->position();
     }
 
     // Zoom/unzoom the display by wheel
     if (event->type() == QEvent::Wheel) {
-      QWheelEvent *wheelEvent = static_cast<QWheelEvent *>(event);
+      QWheelEvent *wheelEvent = dynamic_cast<QWheelEvent *>(event);
       if (wheelEvent->angleDelta().y() > 0) {
         zoomIn();
       }
@@ -1089,7 +1089,7 @@ bool Interactive::eventFilter(QObject *target, QEvent *event) {
       return true;
     }
     if (event->type() == QEvent::MouseButtonPress) {
-      QMouseEvent *mouseEvent = static_cast<QMouseEvent *>(event);
+      QMouseEvent *mouseEvent = dynamic_cast<QMouseEvent *>(event);
       if (mouseEvent->buttons() == Qt::MiddleButton) {
         qApp->setOverrideCursor(Qt::ClosedHandCursor);
         panReferenceClick = mouseEvent->localPos();

src/interactive.h

@@ -74,6 +74,10 @@ class Interactive : public QMainWindow {
 
  public:
   explicit Interactive(QWidget *parent = nullptr);
+  Interactive(const Interactive &T) = delete;
+  Interactive &operator=(const Interactive &T) = delete;
+  Interactive &operator=(Interactive &&T) = delete;
+  Interactive(Interactive &&T) = delete;
   ~Interactive();
 
  private slots:
@@ -94,7 +98,7 @@ class Interactive : public QMainWindow {
   void computeBackground();
   void selectBackground();
 
-  bool eventFilter(QObject *target, QEvent *event);
+  bool eventFilter(QObject *target, QEvent *event) override;
   void crop();
   void reset();